Disable library dependencies check by default (instrumented libs).

third_party/instrumented_libraries/download_build_install.py

 #!/usr/bin/python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Downloads, builds (with instrumentation) and installs shared libraries."""
 
 import argparse
 import os
 import shutil
@@ skipping 34 matching lines @@
 
 def get_library_build_dependencies(library):
   command = 'apt-get -s build-dep %s | grep Inst | cut -d " " -f 2' % library
   command_result = subprocess.Popen(command, stdout=subprocess.PIPE,
       shell=True)
   if command_result.wait():
     raise Exception("Failed to determine build dependencies for %s" % library)
   build_dependencies = [l.strip() for l in command_result.stdout]
   return build_dependencies
 
+def check_library_build_dependencies(library):
+  build_dependencies = get_library_build_dependencies(library)
+  if len(build_dependencies):
+    print >> sys.stderr, 'Please, install build-dependencies for %s' % library
+    print >> sys.stderr, 'One-liner for APT:'
+    print >> sys.stderr, 'sudo apt-get -y --no-remove build-dep %s' % library
+    sys.exit(1)
 
 def shell_call(command, verbose=False, environment=None):
   """ Wrapper on subprocess.Popen
   
   Calls command with specific environment and verbosity using
   subprocess.Popen
   
   Args:
     command: Command to run in shell.
     verbose: If False, hides all stdout and stderr in case of successful build.
@@ skipping 45 matching lines @@
         parsed_arguments.verbose)
     # There should be exactly one subdirectory after downloading a package.
     subdirectories = [d for d in os.listdir('.') if os.path.isdir(d)]
     if len(subdirectories) != 1:
       raise Exception('There was not one directory after downloading ' \
           'a package %s' % parsed_arguments.library)
     with ScopedChangeDirectory(subdirectories[0]):
       # Now we are in the package directory.
       configure_command = './configure %s --prefix=%s' % (
           parsed_arguments.custom_configure_flags, install_prefix)
-      shell_call(configure_command, parsed_arguments.verbose, environment)
-      shell_call('make -j%s' % parsed_arguments.jobs, parsed_arguments.verbose)
-      shell_call('make -j%s install' % parsed_arguments.jobs,
-          parsed_arguments.verbose)
-  
+      try:
+        shell_call(configure_command, parsed_arguments.verbose, environment)
+        shell_call('make -j%s' % parsed_arguments.jobs,
+            parsed_arguments.verbose, environment)
+        shell_call('make -j%s install' % parsed_arguments.jobs,
+            parsed_arguments.verbose, environment)
+      except Exception as exception:
+        print exception
+        print "Failed to build library %s." % parsed_arguments.library
+        print "Probably, some of its dependencies are not installed: %s" % \

[Alexander Potapenko, 2013/12/17 14:14:13]

Please use () to wrap the line, i.e.:

print (... %
       ...)

[alextaran1, 2013/12/17 14:27:57]

Done.

+            ' '.join(get_library_build_dependencies(parsed_arguments.library))
+        sys.exit(1)
+
   # Touch a txt file to indicate library is installed.
   open('%s/%s.txt' % (install_prefix, parsed_arguments.library), 'w').close()
 
   # Remove downloaded package and generated temporary build files.
   shutil.rmtree(library_directory)
 
 
 def main():
   argument_parser = argparse.ArgumentParser(
       description = 'Download, build and install instrumented library')
   
   argument_parser.add_argument('-j', '--jobs', type=int, default=1)
   argument_parser.add_argument('-l', '--library', required=True)
   argument_parser.add_argument('-i', '--product-directory', default='.',
       help='Relative path to the directory with chrome binaries')
   argument_parser.add_argument('-m', '--intermediate-directory', default='.',
       help='Relative path to the directory for temporary build files')
   argument_parser.add_argument('-c', '--custom-configure-flags', default='')
   argument_parser.add_argument('-s', '--sanitizer-type', required=True,
       choices=SUPPORTED_SANITIZERS.keys()) 
   argument_parser.add_argument('-v', '--verbose', action='store_true')
- 
+  argument_parser.add_argument('--check-build-deps', action='store_true')
+
   # Ignore all empty arguments because in several cases gyp passes them to the
   # script, but ArgumentParser treats them as positional arguments instead of
   # ignoring (and doesn't have such options).
   parsed_arguments = argument_parser.parse_args(
       [arg for arg in sys.argv[1:] if len(arg) != 0])
   # Ensure current working directory is this script directory.
   os.chdir(get_script_absolute_path())
   # Ensure all build dependencies are installed.
-  build_dependencies = get_library_build_dependencies(parsed_arguments.library)
-  if len(build_dependencies):
-    print >> sys.stderr, 'Please, install build-dependencies for %s' % \
-        parsed_arguments.library
-    print >> sys.stderr, 'One-liner for APT:'
-    print >> sys.stderr, 'sudo apt-get -y --no-remove build-dep %s' % \
-        parsed_arguments.library
-    sys.exit(1)
-
+  if parsed_arguments.check_build_deps:
+    check_library_build_dependencies(parsed_arguments.library)
+    
   download_build_install(parsed_arguments)
 
 
 if __name__ == '__main__':
   main()