Issue 1134423002: Revert of [bindings] Remove usage of custom binding for namedPropertyQuery of CSSStyleDeclaration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1134423002: Revert of [bindings] Remove usage of custom binding for namedPropertyQuery of CSSStyleDeclaration (Closed)

Created:
5 years, 7 months ago by vivekg

Modified:
5 years, 7 months ago

Reviewers:
haraken, vivekg_samsung

CC:
vivekg, darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, Inactive, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, vivekg_samsung

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of [bindings] Remove usage of custom binding for namedPropertyQuery of CSSStyleDeclaration (patchset #1 id:1 of https://codereview.chromium.org/1120253002/) Reason for revert: Reverting due to the dromeo.jslibstylejquery regression BUG=483448 TBR=haraken@chromium.org Original issue's description: > [bindings] Remove usage of custom binding for namedPropertyQuery of CSSStyleDeclaration > > BUG=345519 > > R=haraken@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194846 TBR=haraken@chromium.org,vivek.vg@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=345519 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195361

Patch Set 1 #

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -11 lines)			Patch
M	Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSStyleDeclaration.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/CSSStyleDeclaration.cpp	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/core/css/CSSStyleDeclaration.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vivekg

Created Revert of [bindings] Remove usage of custom binding for namedPropertyQuery of CSSStyleDeclaration

5 years, 7 months ago (2015-05-14 16:23:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134423002/1

5 years, 7 months ago (2015-05-14 16:23:59 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195361

5 years, 7 months ago (2015-05-14 16:24:31 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages