runtime/vm/intermediate_language.h - Issue 11344011: Relational comparisons for unboxed mints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.h

Issue 11344011: Relational comparisons for unboxed mints. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: addressed Srdjan's comments. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intermediate_language.h

===================================================================

--- runtime/vm/intermediate_language.h (revision 14174)

+++ runtime/vm/intermediate_language.h (working copy)

@@ -2325,10 +2325,12 @@

virtual bool CanDeoptimize() const {

return (operands_class_id() != kDoubleCid)

+ && (operands_class_id() != kMintCid)

&& (operands_class_id() != kSmiCid);

}

virtual bool HasSideEffect() const {

return (operands_class_id() != kDoubleCid)

+ && (operands_class_id() != kMintCid)

&& (operands_class_id() != kSmiCid);

}

@@ -2344,7 +2346,9 @@

virtual Representation RequiredInputRepresentation(intptr_t idx) const {

ASSERT((idx == 0) || (idx == 1));

- return (operands_class_id() == kDoubleCid) ? kUnboxedDouble : kTagged;

+ if (operands_class_id() == kDoubleCid) return kUnboxedDouble;

+ if (operands_class_id() == kMintCid) return kUnboxedMint;

+ return kTagged;

}

private:

« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »