Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 11344011: Relational comparisons for unboxed mints. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed Srdjan's comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 14174)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -1251,33 +1251,39 @@
static void HandleRelationalOp(FlowGraphOptimizer* optimizer,
RelationalOpInstr* comp,
Instruction* instr) {
- if (!comp->HasICData()) return;
-
+ if (!comp->HasICData() || (comp->ic_data()->NumberOfChecks() == 0)) {
+ return;
+ }
const ICData& ic_data = *comp->ic_data();
- if (ic_data.NumberOfChecks() == 0) return;
- // TODO(srdjan): Add multiple receiver type support.
- if (ic_data.NumberOfChecks() != 1) return;
- ASSERT(ic_data.HasOneTarget());
-
- if (HasOnlyTwoSmis(ic_data)) {
- optimizer->InsertBefore(
- instr,
- new CheckSmiInstr(comp->left()->Copy(), comp->deopt_id()),
- instr->env(),
- Definition::kEffect);
- optimizer->InsertBefore(
- instr,
- new CheckSmiInstr(comp->right()->Copy(), comp->deopt_id()),
- instr->env(),
- Definition::kEffect);
- comp->set_operands_class_id(kSmiCid);
- } else if (ShouldSpecializeForDouble(ic_data)) {
- comp->set_operands_class_id(kDoubleCid);
- } else if (comp->ic_data()->AllReceiversAreNumbers()) {
- comp->set_operands_class_id(kNumberCid);
+ if (ic_data.NumberOfChecks() == 1) {
+ ASSERT(ic_data.HasOneTarget());
+ if (HasOnlyTwoSmis(ic_data)) {
+ optimizer->InsertBefore(
+ instr,
+ new CheckSmiInstr(comp->left()->Copy(), comp->deopt_id()),
+ instr->env(),
+ Definition::kEffect);
+ optimizer->InsertBefore(
+ instr,
+ new CheckSmiInstr(comp->right()->Copy(), comp->deopt_id()),
+ instr->env(),
+ Definition::kEffect);
+ comp->set_operands_class_id(kSmiCid);
+ } else if (ShouldSpecializeForDouble(ic_data)) {
+ comp->set_operands_class_id(kDoubleCid);
+ } else if (HasTwoMintOrSmi(*comp->ic_data()) &&
+ FlowGraphCompiler::SupportsUnboxedMints()) {
+ comp->set_operands_class_id(kMintCid);
+ } else {
+ ASSERT(comp->operands_class_id() == kIllegalCid);
+ }
+ } else if (HasTwoMintOrSmi(*comp->ic_data()) &&
+ FlowGraphCompiler::SupportsUnboxedMints()) {
+ comp->set_operands_class_id(kMintCid);
}
}
+
void FlowGraphOptimizer::VisitRelationalOp(RelationalOpInstr* instr) {
HandleRelationalOp(this, instr, instr);
}
@@ -1333,8 +1339,6 @@
} else if (HasTwoMintOrSmi(*comp->ic_data()) &&
FlowGraphCompiler::SupportsUnboxedMints()) {
comp->set_receiver_class_id(kMintCid);
- } else if (comp->ic_data()->AllReceiversAreNumbers()) {
- comp->set_receiver_class_id(kNumberCid);
}
if (comp->receiver_class_id() != kIllegalCid) {
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698