Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1134333003: Revert of Enable extension browser tests on debug windows. (Closed)

Created:
5 years, 7 months ago by sergeyv
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable extension browser tests on debug windows. (patchset #1 id:1 of https://codereview.chromium.org/1128253005/) Reason for revert: GcdPrivateAPITest.WifiPasswords fails after this patch. Failure example: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=37938 Original issue's description: > Enable extension browser tests on debug windows. > > BUG=177163 > > Committed: https://crrev.com/121cbb5f7fce9719ab6152cb2e059575df8139d6 > Cr-Commit-Position: refs/heads/master@{#329495} TBR=asargent@chromium.org,hubbe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=177163 Committed: https://crrev.com/a4600cde0f38322abdb7e1ad9dbbfad2c8553daa Cr-Commit-Position: refs/heads/master@{#329622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/extensions/extension_apitest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sergeyv
Created Revert of Enable extension browser tests on debug windows.
5 years, 7 months ago (2015-05-13 12:56:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134333003/1
5 years, 7 months ago (2015-05-13 12:56:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 12:57:36 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 12:59:29 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4600cde0f38322abdb7e1ad9dbbfad2c8553daa
Cr-Commit-Position: refs/heads/master@{#329622}

Powered by Google App Engine
This is Rietveld 408576698