Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Side by Side Diff: chrome/browser/extensions/extension_apitest.cc

Issue 1134333003: Revert of Enable extension browser tests on debug windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 6
7 #include "base/strings/string_split.h" 7 #include "base/strings/string_split.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "chrome/browser/extensions/extension_service.h" 10 #include "chrome/browser/extensions/extension_service.h"
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 return RunExtensionTestImpl(extension_name, std::string(), NULL, kFlagNone); 198 return RunExtensionTestImpl(extension_name, std::string(), NULL, kFlagNone);
199 } 199 }
200 200
201 bool ExtensionApiTest::RunExtensionTestIncognitoNoFileAccess( 201 bool ExtensionApiTest::RunExtensionTestIncognitoNoFileAccess(
202 const std::string& extension_name) { 202 const std::string& extension_name) {
203 return RunExtensionTestImpl( 203 return RunExtensionTestImpl(
204 extension_name, std::string(), NULL, kFlagEnableIncognito); 204 extension_name, std::string(), NULL, kFlagEnableIncognito);
205 } 205 }
206 206
207 bool ExtensionApiTest::ExtensionSubtestsAreSkipped() { 207 bool ExtensionApiTest::ExtensionSubtestsAreSkipped() {
208 // See http://crbug.com/177163 for details.
209 #if defined(OS_WIN) && !defined(NDEBUG)
210 LOG(WARNING) << "Workaround for 177163, prematurely returning";
211 return true;
212 #else
208 return false; 213 return false;
214 #endif
209 } 215 }
210 216
211 bool ExtensionApiTest::RunExtensionSubtest(const std::string& extension_name, 217 bool ExtensionApiTest::RunExtensionSubtest(const std::string& extension_name,
212 const std::string& page_url) { 218 const std::string& page_url) {
213 return RunExtensionSubtest(extension_name, page_url, kFlagEnableFileAccess); 219 return RunExtensionSubtest(extension_name, page_url, kFlagEnableFileAccess);
214 } 220 }
215 221
216 bool ExtensionApiTest::RunExtensionSubtest(const std::string& extension_name, 222 bool ExtensionApiTest::RunExtensionSubtest(const std::string& extension_name,
217 const std::string& page_url, 223 const std::string& page_url,
218 int flags) { 224 int flags) {
(...skipping 190 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 test_config_->SetInteger(kSpawnedTestServerPort, 415 test_config_->SetInteger(kSpawnedTestServerPort,
410 test_server()->host_port_pair().port()); 416 test_server()->host_port_pair().port());
411 417
412 return true; 418 return true;
413 } 419 }
414 420
415 void ExtensionApiTest::SetUpCommandLine(base::CommandLine* command_line) { 421 void ExtensionApiTest::SetUpCommandLine(base::CommandLine* command_line) {
416 ExtensionBrowserTest::SetUpCommandLine(command_line); 422 ExtensionBrowserTest::SetUpCommandLine(command_line);
417 test_data_dir_ = test_data_dir_.AppendASCII("api_test"); 423 test_data_dir_ = test_data_dir_.AppendASCII("api_test");
418 } 424 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698