Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1134303009: Revert of Revert of Move content:: scheme registrations from chrome/ to content/. (Closed)

Created:
5 years, 7 months ago by Mike West
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move content:: scheme registrations from chrome/ to content/. Both 'chrome:' and 'chrome-devtools:' are content-level schemes; we should do their various renderer-side scheme registrations in content (RenderThreadImpl::RegisterSchemes) rather than in chrome (ChromeContentRendererClient::RenderThreadStarted). Patch 1: https://codereview.chromium.org/1143593006 Patch 2: [This patch] Patch 3: https://codereview.chromium.org/1139053004/ This is a re-land of https://codereview.chromium.org/1137103003/, which was reverted due to trivial layout test changes. TBR=jochen@chromium.org,philipj@opera.com,sofbjornf@opera.com,hiroshige@chromium.org BUG=489672 Committed: https://crrev.com/8e94fb30db172bcc6bd4f22c84bf92ae6e18acb1 Cr-Commit-Position: refs/heads/master@{#330700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +6 lines, -16 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Mike West
Created Revert of Revert of Move content:: scheme registrations from chrome/ to content/.
5 years, 7 months ago (2015-05-19 19:07:53 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134303009/1
5 years, 7 months ago (2015-05-19 19:10:58 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-19 20:24:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134303009/1
5 years, 7 months ago (2015-05-20 05:01:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 05:05:23 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 05:06:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e94fb30db172bcc6bd4f22c84bf92ae6e18acb1
Cr-Commit-Position: refs/heads/master@{#330700}

Powered by Google App Engine
This is Rietveld 408576698