Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 11343020: Merge 132746 (partial) - [Chromium] Find-in-page reports matches in hidden iframes (Closed)

Created:
8 years, 1 month ago by abarth-chromium
Modified:
8 years, 1 month ago
Reviewers:
abarth
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Visibility:
Public.

Description

Merge 132746 (partial) - [Chromium] Find-in-page reports matches in hidden iframes https://bugs.webkit.org/show_bug.cgi?id=100604 Reviewed by Eric Seidel. This is actually a regression caused by http://trac.webkit.org/changeset/128784. This patch adds back some code removed in WebFrameImpl::shouldScopeMatches in r128784. This patch also introduces a test so that we don't make this mistake again. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::shouldScopeMatches): TBR=abarth@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/WebKit/chromium/src/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
abarth-chromium
8 years, 1 month ago (2012-10-29 18:54:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698