Source/WebKit/chromium/src/WebFrameImpl.cpp - Issue 11343020: Merge 132746 (partial) - [Chromium] Find-in-page reports matches in hidden iframes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/WebFrameImpl.cpp

Issue 11343020: Merge 132746 (partial) - [Chromium] Find-in-page reports matches in hidden iframes (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1271/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebKit/chromium/src/WebFrameImpl.cpp

===================================================================

--- Source/WebKit/chromium/src/WebFrameImpl.cpp (revision 132831)

+++ Source/WebKit/chromium/src/WebFrameImpl.cpp (working copy)

@@ -2576,7 +2576,7 @@

{

// Don't scope if we can't find a frame or a view.

// The user may have closed the tab/application, so abort.

- if (!frame() || !frame()->view())

+ if (!frame() || !frame()->view() || !hasVisibleContent())

return false;

ASSERT(frame()->document() && frame()->view());

« no previous file with comments | « no previous file | no next file » | no next file with comments »