Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: tests/standalone/io/process_exit_negative_test.dart

Issue 11343009: Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your stream… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/process_check_arguments_test.dart ('k') | tests/standalone/io/process_exit_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/process_exit_negative_test.dart
diff --git a/tests/standalone/io/process_exit_negative_test.dart b/tests/standalone/io/process_exit_negative_test.dart
index 0e5e445c84a60e78020e05e596a3cbad54d5234c..caf5cfbcb334a900967f6a2e8f5a153ca37c8e24 100644
--- a/tests/standalone/io/process_exit_negative_test.dart
+++ b/tests/standalone/io/process_exit_negative_test.dart
@@ -13,6 +13,8 @@ void main() {
const ["0", "0", "0", "0"]);
p.onExit = (int s) {
print(a.toString()); // Should cause a compilation error here.
- p.close();
};
+ // Drain stdout and stderr.
+ p.stdout.onData = p.stdout.read;
+ p.stderr.onData = p.stderr.read;
}
« no previous file with comments | « tests/standalone/io/process_check_arguments_test.dart ('k') | tests/standalone/io/process_exit_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698