Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: tests/standalone/io/process_check_arguments_test.dart

Issue 11343009: Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your stream… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/io/process_check_arguments_test.dart
diff --git a/tests/standalone/io/process_check_arguments_test.dart b/tests/standalone/io/process_check_arguments_test.dart
index cc0f5e73f6b20cae5afe1a343cb1849b89cccfda..1e97c8d7a20593ed2262031e9dbdde53875458b5 100644
--- a/tests/standalone/io/process_check_arguments_test.dart
+++ b/tests/standalone/io/process_check_arguments_test.dart
@@ -10,8 +10,10 @@ test(args) {
future.then((process) {
process.onExit = (exitCode) {
Expect.equals(0, exitCode);
- process.close();
};
+ // Drain stdout and stderr.
+ process.stdout.onData = process.stdout.read;
+ process.stderr.onData = process.stderr.read;
});
}
« no previous file with comments | « tests/standalone/io/process_broken_pipe_test.dart ('k') | tests/standalone/io/process_exit_negative_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698