Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1134213006: Hide the "Add new services" menu from Files app when running as dialog. (Closed)

Created:
5 years, 7 months ago by mtomasz
Modified:
5 years, 7 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide the "Add new services" menu from Files app when running as dialog. TEST=Tested manually in open dialog, and standalone Files app. BUG=487905 Committed: https://crrev.com/f73adcf5aae849b0508435c6888b09993daa8608 Cr-Commit-Position: refs/heads/master@{#329804}

Patch Set 1 #

Patch Set 2 : Fixed tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 chunk +4 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/navigation_list_model.js View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js View 1 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtomasz
@yawano: PTAL. Thanks.
5 years, 7 months ago (2015-05-14 02:29:46 UTC) #2
yawano
lgtm.
5 years, 7 months ago (2015-05-14 04:02:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134213006/20001
5 years, 7 months ago (2015-05-14 04:21:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 04:49:20 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 04:50:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f73adcf5aae849b0508435c6888b09993daa8608
Cr-Commit-Position: refs/heads/master@{#329804}

Powered by Google App Engine
This is Rietveld 408576698