ui/file_manager/file_manager/foreground/js/file_manager_commands.js - Issue 1134213006: Hide the "Add new services" menu from Files app when running as dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Issue 1134213006: Hide the "Add new services" menu from Files app when running as dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed tests. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/file_manager.js ('k') | ui/file_manager/file_manager/foreground/js/navigation_list_model.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/file_manager_commands.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

index 6463a9fe9d6cd5fbb6371087f0e10f50d0f4e3eb..b658b19ef8d20d0c54038a8bf04e0c02ef0652b1 100644

--- a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

+++ b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

@@ -1318,5 +1318,8 @@ CommandHandler.COMMANDS_['install-new-extension'] = /** @type {Command} */ ({

fileManager.providersModel.requestMount(assert(itemId));

});

- canExecute: CommandUtil.canExecuteAlways

+ canExecute: function(event, fileManager) {

+ event.canExecute = fileManager.dialogType === DialogType.FULL_PAGE;

+ event.command.setHidden(!event.canExecute);

+ }

});