Issue 11342028: Fix wrong canonicalization of signature class due to name collision (issue 6353).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11342028: Fix wrong canonicalization of signature class due to name collision (issue 6353). (Closed)

Created:
8 years, 1 month ago by regis

Modified:
8 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix wrong canonicalization of signature class due to name collision (issue 6353). Add test. Committed: https://code.google.com/p/dart/source/detail?r=14234

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -11 lines)			Patch
M	runtime/vm/object.h	View	1	1 chunk	+6 lines, -5 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	4 chunks	+8 lines, -5 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/language/closure8_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/11342028/diff/1/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/11342028/diff/1/runtime/vm/object.h#newcode1065 runtime/vm/object.h:1065: // internal signature of the given function. Maybe ...

8 years, 1 month ago (2012-10-30 00:00:57 UTC) #2

regis

8 years, 1 month ago (2012-10-30 00:06:16 UTC) #3

Thanks!

https://codereview.chromium.org/11342028/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/11342028/diff/1/runtime/vm/object.h#newcode1065
runtime/vm/object.h:1065: // internal signature of the given function.
On 2012/10/30 00:00:57, srdjan wrote:
> Maybe say what is class, what is type parameter.

Done.

Expand Messages | Collapse Messages

Issue 11342028: Fix wrong canonicalization of signature class due to name collision (issue 6353). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages