Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: runtime/vm/object.h

Issue 11342028: Fix wrong canonicalization of signature class due to name collision (issue 6353). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 14233)
+++ runtime/vm/object.h (working copy)
@@ -1061,17 +1061,18 @@
RawString* QualifiedUserVisibleName() const;
virtual RawString* DictionaryName() const { return name(); }
- // Build a string of the form '<T, R>(T, [b: B, c: C]) => R' representing the
- // internal signature of the given function.
+ // Build a string of the form 'C<T, R>(T, {b: B, c: C}) => R' representing the
+ // internal signature of the given function. In this example, T and R are
+ // type parameters of class C, the owner of the function.
RawString* Signature() const {
const bool instantiate = false;
return BuildSignature(instantiate, kInternalName, TypeArguments::Handle());
}
- // Build a string of the form '(A, [b: B, c: C]) => D' representing the
+ // Build a string of the form '(A, {b: B, c: C}) => D' representing the
// signature of the given function, where all generic types (e.g. '<T, R>' in
- // '<T, R>(T, [b: B, c: C]) => R') are instantiated using the given
- // instantiator type argument vector (e.g. '<A, D>').
+ // 'C<T, R>(T, {b: B, c: C}) => R') are instantiated using the given
+ // instantiator type argument vector of a C instance (e.g. '<A, D>').
RawString* InstantiatedSignatureFrom(
const AbstractTypeArguments& instantiator,
NameVisibility name_visibility) const {
« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698