Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Issue 1134163003: [Effen] Use the checkbox widget in the stocks app. (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Use the checkbox widget in the stocks app. - add a checkbox to the stock app, so that we're testing the checkbox widget (it's not currently wired up to anything, that can come later) - make InkSplash use FlexContainer so that we can use flex in the popup menu items - make effen's Text be more similar to Image and Container, so that it can be styled - make layout.dart's RenderCSSText correctly support being styled - also fixes a bug with the stock list where we were rendering one too few a row when scrolling - check in the code to dump the DOM so I don't have to keep remembering how to do this R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f9e940c3a32cbd4379ad2cc1b3ef1a3f8e8a761e

Patch Set 1 #

Patch Set 2 : fix tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -33 lines) Patch
M sky/examples/stocks/lib/stock_app.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M sky/examples/stocks/lib/stock_menu.dart View 2 chunks +15 lines, -3 lines 0 comments Download
M sky/framework/components/checkbox.dart View 1 chunk +1 line, -0 lines 1 comment Download
M sky/framework/components/fixed_height_scrollable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/components/ink_well.dart View 3 chunks +4 lines, -1 line 0 comments Download
M sky/framework/fn.dart View 2 chunks +30 lines, -25 lines 0 comments Download
M sky/framework/layout.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M sky/tests/framework/basic-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm https://codereview.chromium.org/1134163003/diff/20001/sky/framework/components/checkbox.dart File sky/framework/components/checkbox.dart (right): https://codereview.chromium.org/1134163003/diff/20001/sky/framework/components/checkbox.dart#newcode7 sky/framework/components/checkbox.dart:7: import 'dart:sky' as sky; Do you want this?
5 years, 7 months ago (2015-05-12 21:34:42 UTC) #2
Hixie
5 years, 7 months ago (2015-05-12 21:39:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f9e940c3a32cbd4379ad2cc1b3ef1a3f8e8a761e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698