sky/framework/components/fixed_height_scrollable.dart - Issue 1134163003: [Effen] Use the checkbox widget in the stocks app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/framework/components/fixed_height_scrollable.dart

Issue 1134163003: [Effen] Use the checkbox widget in the stocks app. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: fix tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/framework/components/fixed_height_scrollable.dart

diff --git a/sky/framework/components/fixed_height_scrollable.dart b/sky/framework/components/fixed_height_scrollable.dart

index 2838acbfa6a230bf32d0549c7c123b92ac17c023..e54ebafa2a9c4561a215b87ace49c33da2f55e68 100644

--- a/sky/framework/components/fixed_height_scrollable.dart

+++ b/sky/framework/components/fixed_height_scrollable.dart

@@ -77,7 +77,7 @@ abstract class FixedHeightScrollable extends Scrollable {

transformStyle =

'transform: translateY(${(-scrollOffset).toStringAsFixed(2)}px)';

} else {

- drawCount = (_height / _itemHeight).round() + 1;

+ drawCount = (_height / _itemHeight).ceil() + 1;

double alignmentDelta = -scrollOffset % _itemHeight;

if (alignmentDelta != 0.0)

alignmentDelta -= _itemHeight;