Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 11340059: [VS Addin] Disable PNaCl adding tests until newer SDK is available (Closed)

Created:
8 years, 1 month ago by Sam Clegg
Modified:
8 years, 1 month ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[VS Addin] Disable PNaCl adding tests until newer SDK is available. This should fix the current test failures on the bot. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1460

Patch Set 1 : #

Total comments: 4

Messages

Total messages: 2 (0 generated)
Sam Clegg
This change will make the Addin tree green again. Currently there is no public SDK ...
8 years, 1 month ago (2012-10-31 03:16:34 UTC) #1
binji
8 years, 1 month ago (2012-10-31 06:36:22 UTC) #2
lgtm

https://chromiumcodereview.appspot.com/11340059/diff/1001/visual_studio/Nativ...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs
(right):

https://chromiumcodereview.appspot.com/11340059/diff/1001/visual_studio/Nativ...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs:289: // If
multiprocess complication is enabled (not the VS default)
sp: compilation

https://chromiumcodereview.appspot.com/11340059/diff/1001/visual_studio/Nativ...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs:297:
MessageBox.Show("Multi-processor Compilation with NaCl requires that python " +
maybe this should be Log.LogError like above?

https://chromiumcodereview.appspot.com/11340059/diff/1001/visual_studio/Nativ...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs
(right):

https://chromiumcodereview.appspot.com/11340059/diff/1001/visual_studio/Nativ...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs:46: public
static int GetSDKVersion(string root, out int revision)
seems a little strange to me to have a return value and an out value, but OK

https://chromiumcodereview.appspot.com/11340059/diff/1001/visual_studio/Nativ...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs:48: //
Determin version by parsing top level README file.
sp: Determine

Powered by Google App Engine
This is Rietveld 408576698