Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs

Issue 11340059: [VS Addin] Disable PNaCl adding tests until newer SDK is available (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs
diff --git a/visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs b/visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs
index 5cc6b431ad8bb5d252ee66dbaef5d6104aedb787..b759b3fa01d05b21f0871d484eed9003054795d1 100644
--- a/visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs
+++ b/visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs
@@ -5,11 +5,13 @@
namespace UnitTests
{
using System;
+ using System.IO;
using EnvDTE;
using EnvDTE80;
using Microsoft.VisualStudio.TestTools.UnitTesting;
using Microsoft.VisualStudio.VCProjectEngine;
+ using NaCl.Build.CPPTasks;
/// <summary>
/// This test class contains tests related to the custom project settings
@@ -109,12 +111,21 @@ namespace UnitTests
TryCompile(naclSolutionEmptyInitialization, "Release", naclPlatform);
}
+
+
/// <summary>
/// Test method to check that the NaCl platform compiles a test project.
/// </summary>
[TestMethod]
public void CheckPNaClCompile()
{
+ int revision;
+ string root = System.Environment.GetEnvironmentVariable("NACL_SDK_ROOT");
+ SDKUtilities.GetSDKVersion(root, out revision);
+ if (revision < SDKUtilities.MinPNaCLSDKVersion)
+ {
+ Assert.Inconclusive();
+ }
string naclPlatform = NativeClientVSAddIn.Strings.PNaClPlatformName;
TryCompile(naclSolutionEmptyInitialization, "Debug", naclPlatform);
TryCompile(naclSolutionEmptyInitialization, "Release", naclPlatform);

Powered by Google App Engine
This is Rietveld 408576698