Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9803)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1134003009: media: Use mojo::StrongBinding in mojo media services. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/mojo/services/mojo_cdm_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 935a9cf3a16031b0946842d400212f0beab740f6..c3e965b62b4a2b072effb97daaffbb3a4d39c928 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1521,8 +1521,8 @@ void RenderFrameHostImpl::OnHidePopup() {
#if defined(ENABLE_MEDIA_MOJO_RENDERER)
static void CreateMediaRendererService(
mojo::InterfaceRequest<mojo::MediaRenderer> request) {
- media::MojoRendererService* service = new media::MojoRendererService();
- mojo::BindToRequest(service, &request);
+ // The created object is strongly bound to (and owned by) the pipe.
jam 2015/05/20 15:02:23 isn't "strongly bound" and "owned by" redundant? I
xhwang 2015/05/20 18:19:34 Done.
+ new media::MojoRendererService(request.Pass());
}
#endif
« no previous file with comments | « no previous file | media/mojo/services/mojo_cdm_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698