GN: Implement is_lsan, is_tsan and is_msan.

GN: Implement is_lsan, is_tsan and is_msan.

Committed: https://crrev.com/f51e78122a0fa2c42a8dcfea688fb5ebde75e944
Cr-Commit-Position: refs/heads/master@{#330710}

[Sam McNally, 2015-05-18 04:59:03]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2015-05-19 00:55:43]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2015-05-19 03:01:00]

sammc@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-05-19 22:54:28]

https://codereview.chromium.org/1134003008/diff/40001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/1134003008/diff/40001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:80: asan_blacklist =
"//tools/memory/asan/blacklist.txt"
Please don't add any more args to this file. I'm adding some advice in:
https://codereview.chromium.org/1125033004
on what to do instead. Please read that and let me know if it's clear.

Also, do these things really need to be parameterized? Does anybody actually set
the blacklist file from outside the build?

[Sam McNally, 2015-05-20 01:07:21]

https://codereview.chromium.org/1134003008/diff/40001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/1134003008/diff/40001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:80: asan_blacklist =
"//tools/memory/asan/blacklist.txt"
On 2015/05/19 22:54:27, brettw wrote:
> Please don't add any more args to this file. I'm adding some advice in:
> https://codereview.chromium.org/1125033004
> on what to do instead. Please read that and let me know if it's clear.

I think it's clear for args used by a subset of the build, but it doesn't cover
args that BUILDCONFIG.gn depends on. Specifically, if is_asan and friends were
moved into a sanitizers.gni, how could is_clang and symbol_level be set
depending on those args?
> 
> Also, do these things really need to be parameterized? Does anybody actually
set
> the blacklist file from outside the build?

As far as I can tell nothing is setting custom blacklist files. Removed them.
msan_track_origins is a documented option.

[brettw, 2015-05-20 05:34:58]

On 2015/05/20 01:07:21, Sam McNally wrote:
>
https://codereview.chromium.org/1134003008/diff/40001/build/config/BUILDCONFI...
> File build/config/BUILDCONFIG.gn (right):
> 
>
https://codereview.chromium.org/1134003008/diff/40001/build/config/BUILDCONFI...
> build/config/BUILDCONFIG.gn:80: asan_blacklist =
> "//tools/memory/asan/blacklist.txt"
> On 2015/05/19 22:54:27, brettw wrote:
> > Please don't add any more args to this file. I'm adding some advice in:
> > https://codereview.chromium.org/1125033004
> > on what to do instead. Please read that and let me know if it's clear.
> 
> I think it's clear for args used by a subset of the build, but it doesn't
cover
> args that BUILDCONFIG.gn depends on. Specifically, if is_asan and friends were
> moved into a sanitizers.gni, how could is_clang and symbol_level be set
> depending on those args?

Yeah, sorry if I was unclear, I was talking only about your new ones. It's great
we could just hardcode the file names.

I think msan_track_origins can be moved to build/config/compiler/BUILD.gn and
then this looks fine.

[Sam McNally, 2015-05-20 06:06:40]

On 2015/05/20 05:34:58, brettw wrote:
> On 2015/05/20 01:07:21, Sam McNally wrote:
> >
>
https://codereview.chromium.org/1134003008/diff/40001/build/config/BUILDCONFI...
> > File build/config/BUILDCONFIG.gn (right):
> > 
> >
>
https://codereview.chromium.org/1134003008/diff/40001/build/config/BUILDCONFI...
> > build/config/BUILDCONFIG.gn:80: asan_blacklist =
> > "//tools/memory/asan/blacklist.txt"
> > On 2015/05/19 22:54:27, brettw wrote:
> > > Please don't add any more args to this file. I'm adding some advice in:
> > > https://codereview.chromium.org/1125033004
> > > on what to do instead. Please read that and let me know if it's clear.
> > 
> > I think it's clear for args used by a subset of the build, but it doesn't
> cover
> > args that BUILDCONFIG.gn depends on. Specifically, if is_asan and friends
were
> > moved into a sanitizers.gni, how could is_clang and symbol_level be set
> > depending on those args?
> 
> Yeah, sorry if I was unclear, I was talking only about your new ones. It's
great
> we could just hardcode the file names.
> 
> I think msan_track_origins can be moved to build/config/compiler/BUILD.gn and
> then this looks fine.

Done.

[brettw, 2015-05-20 06:07:45]

LGTM thanks

[Sam McNally, 2015-05-20 07:29:33]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2015-05-20 07:29:34]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1134003008/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2015-05-20 07:30:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134003008/100001

[commit-bot: I haz the power, 2015-05-20 07:34:06]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-05-20 07:34:44]

Patchset 4 (id:??) landed as
https://crrev.com/f51e78122a0fa2c42a8dcfea688fb5ebde75e944
Cr-Commit-Position: refs/heads/master@{#330710}