Clarify and update GN build flags docs.

Clarify and update GN build flags docs.

Some of the documentation was unclear and out-of-date, and also didn't really list what to do instead.

Committed: https://crrev.com/8a05b7f011a620b2bb1046acacb4a5ac0f667603
Cr-Commit-Position: refs/heads/master@{#330761}

[brettw, 2015-05-19 22:52:05]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-05-19 22:52:11]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-19 22:54:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125033004/20001

[commit-bot: I haz the power, 2015-05-20 00:24:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-20 00:24:59]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2015-05-20 02:21:29]

lgtm w/ edits.

https://codereview.chromium.org/1125033004/diff/20001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/1125033004/diff/20001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:47: #   config in foo's public_configs. This will
propgate that define to all the
typo: "propagate".

https://codereview.chromium.org/1125033004/diff/20001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:72: # - Name like "use_foo" or "is_foo" (whatever is
more appropriate for your
"Name like" is awkward. "Use a name like" or just "Use", maybe?

https://codereview.chromium.org/1125033004/diff/20001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:79: #   even if the value is overridden which is
wasteful. See first bullet.
add a comma after overridden:

    even if the value is overridden, which is wasteful.

https://codereview.chromium.org/1125033004/diff/20001/build/config/ui.gni
File build/config/ui.gni (right):

https://codereview.chromium.org/1125033004/diff/20001/build/config/ui.gni#new...
build/config/ui.gni:6: # featyre-related ones). These should theoretically be
moved to the ui
typo: "feature-related". Maybe also change "ui" to "//ui" ?

https://codereview.chromium.org/1125033004/diff/20001/build/config/ui.gni#new...
build/config/ui.gni:11: # anything that needs a grit define must be in either
this file or ui.gni.
"either this file or features.gni". This is ui.gni :).

[brettw, 2015-05-20 16:51:36]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-05-20 16:51:36]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1125033004/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2015-05-20 16:51:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125033004/40001

[commit-bot: I haz the power, 2015-05-20 17:32:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-20 17:34:09]

Patchset 3 (id:??) landed as
https://crrev.com/8a05b7f011a620b2bb1046acacb4a5ac0f667603
Cr-Commit-Position: refs/heads/master@{#330761}