Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133933002: Move //services/files/c -> //mojo/services/files/public/c. (Closed)

Created:
5 years, 7 months ago by viettrungluu
Modified:
5 years, 7 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove data dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -3531 lines) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/BUILD.gn View 1 3 chunks +25 lines, -14 lines 0 comments Download
A + mojo/services/files/public/c/lib/directory_wrapper.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/public/c/lib/directory_wrapper.cc View 1 chunk +8 lines, -8 lines 0 comments Download
A + mojo/services/files/public/c/lib/errno_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/files/public/c/lib/fd_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/public/c/lib/fd_table.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/lib/fd_table.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/public/c/lib/file_fd_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/files/public/c/lib/file_fd_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + mojo/services/files/public/c/lib/mojio_fcntl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/services/files/public/c/lib/mojio_sys_stat.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/files/public/c/lib/mojio_unistd.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/services/files/public/c/lib/real_errno_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/lib/real_errno_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/lib/singletons.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/lib/singletons.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/services/files/public/c/lib/template_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/files/public/c/lib/util.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/lib/util.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/mojio_config.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/services/files/public/c/mojio_fcntl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/files/public/c/mojio_stdio.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/files/public/c/mojio_sys_stat.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + mojo/services/files/public/c/mojio_sys_types.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/services/files/public/c/mojio_time.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/files/public/c/mojio_unistd.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/services/files/public/c/tests/directory_wrapper_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
A + mojo/services/files/public/c/tests/errno_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/public/c/tests/fd_table_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/files/public/c/tests/file_fd_impl_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
A + mojo/services/files/public/c/tests/mock_errno_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/tests/mock_errno_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/tests/mojio_impl_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/tests/mojio_impl_test_base.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/services/files/public/c/tests/mojio_sys_stat_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/files/public/c/tests/mojio_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/tests/mojio_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/public/c/tests/mojio_unistd_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/files/public/c/tests/real_errno_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/files/public/c/tests/test_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/files/public/c/tests/test_utils.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/files/public/c/tests/test_utils_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/services/files/public/c/tests/util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D services/files/c/BUILD.gn View 1 chunk +0 lines, -81 lines 0 comments Download
D services/files/c/lib/directory_wrapper.h View 1 chunk +0 lines, -44 lines 0 comments Download
D services/files/c/lib/directory_wrapper.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D services/files/c/lib/errno_impl.h View 1 chunk +0 lines, -57 lines 0 comments Download
D services/files/c/lib/fd_impl.h View 1 chunk +0 lines, -57 lines 0 comments Download
D services/files/c/lib/fd_table.h View 1 chunk +0 lines, -56 lines 0 comments Download
D services/files/c/lib/fd_table.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D services/files/c/lib/file_fd_impl.h View 1 chunk +0 lines, -37 lines 0 comments Download
D services/files/c/lib/file_fd_impl.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D services/files/c/lib/mojio_fcntl.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D services/files/c/lib/mojio_sys_stat.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D services/files/c/lib/mojio_unistd.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D services/files/c/lib/real_errno_impl.h View 1 chunk +0 lines, -30 lines 0 comments Download
D services/files/c/lib/real_errno_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D services/files/c/lib/singletons.h View 1 chunk +0 lines, -46 lines 0 comments Download
D services/files/c/lib/singletons.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D services/files/c/lib/template_util.h View 1 chunk +0 lines, -79 lines 0 comments Download
D services/files/c/lib/util.h View 1 chunk +0 lines, -19 lines 0 comments Download
D services/files/c/lib/util.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D services/files/c/mojio_config.h View 1 chunk +0 lines, -38 lines 0 comments Download
D services/files/c/mojio_fcntl.h View 1 chunk +0 lines, -66 lines 0 comments Download
D services/files/c/mojio_stdio.h View 1 chunk +0 lines, -203 lines 0 comments Download
D services/files/c/mojio_sys_stat.h View 1 chunk +0 lines, -128 lines 0 comments Download
D services/files/c/mojio_sys_types.h View 1 chunk +0 lines, -54 lines 0 comments Download
D services/files/c/mojio_time.h View 1 chunk +0 lines, -31 lines 0 comments Download
D services/files/c/mojio_unistd.h View 1 chunk +0 lines, -155 lines 0 comments Download
D services/files/c/tests/directory_wrapper_unittest.cc View 1 chunk +0 lines, -201 lines 0 comments Download
D services/files/c/tests/errno_impl_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D services/files/c/tests/fd_table_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D services/files/c/tests/file_fd_impl_unittest.cc View 1 chunk +0 lines, -282 lines 0 comments Download
D services/files/c/tests/mock_errno_impl.h View 1 chunk +0 lines, -41 lines 0 comments Download
D services/files/c/tests/mock_errno_impl.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D services/files/c/tests/mojio_impl_test_base.h View 1 chunk +0 lines, -36 lines 0 comments Download
D services/files/c/tests/mojio_impl_test_base.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D services/files/c/tests/mojio_sys_stat_unittest.cc View 1 chunk +0 lines, -74 lines 0 comments Download
D services/files/c/tests/mojio_test_base.h View 1 chunk +0 lines, -30 lines 0 comments Download
D services/files/c/tests/mojio_test_base.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D services/files/c/tests/mojio_unistd_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D services/files/c/tests/real_errno_impl_unittest.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D services/files/c/tests/test_utils.h View 1 chunk +0 lines, -50 lines 0 comments Download
D services/files/c/tests/test_utils.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D services/files/c/tests/test_utils_unittest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D services/files/c/tests/util_unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
The tests have a dodgy data dep -- they depend on an implementation of the ...
5 years, 7 months ago (2015-05-08 23:44:41 UTC) #1
jamesr
lgtm https://codereview.chromium.org/1133933002/diff/1/mojo/BUILD.gn File mojo/BUILD.gn (right): https://codereview.chromium.org/1133933002/diff/1/mojo/BUILD.gn#newcode66 mojo/BUILD.gn:66: "//mojo/services/files/public/c:apptests", this whole target is dumb - why ...
5 years, 7 months ago (2015-05-09 00:02:25 UTC) #2
viettrungluu
5 years, 7 months ago (2015-05-09 04:24:33 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
cb317abec2ce4099f32c9c7262f37a3233ac52db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698