Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1659)

Unified Diff: mojo/services/files/public/c/BUILD.gn

Issue 1133933002: Move //services/files/c -> //mojo/services/files/public/c. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: remove data dep Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/BUILD.gn ('k') | mojo/services/files/public/c/lib/directory_wrapper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/files/public/c/BUILD.gn
diff --git a/services/files/c/BUILD.gn b/mojo/services/files/public/c/BUILD.gn
similarity index 61%
rename from services/files/c/BUILD.gn
rename to mojo/services/files/public/c/BUILD.gn
index cedc2a7a3cd187a491199f0af3657ec820789bc0..9cd687be3d8931ba5a99b34a0b631cc8b0df9594 100644
--- a/services/files/c/BUILD.gn
+++ b/mojo/services/files/public/c/BUILD.gn
@@ -2,9 +2,17 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import("//mojo/public/mojo_application.gni")
+import("//build/module_args/mojo.gni")
+import("$mojo_sdk_root/mojo/public/mojo_application.gni")
+import("$mojo_sdk_root/mojo/public/mojo_sdk.gni")
+
+mojo_sdk_source_set("mojio") {
+ # TODO(vtl): This is needed because mojo_sdk.gni doesn't understand relative
+ # dependencies (so without this we can't depend on our interfaces!).
+ restrict_external_deps = false
+
+ public_configs = [ "../../../public/build/config:mojo_services" ]
-source_set("mojio") {
sources = [
"lib/directory_wrapper.cc",
"lib/directory_wrapper.h",
@@ -34,13 +42,18 @@ source_set("mojio") {
]
deps = [
- "//mojo/public/cpp/bindings",
- "//mojo/public/cpp/environment",
- "//mojo/public/cpp/system",
- "//mojo/services/files/public/interfaces",
+ "../interfaces",
+ ]
+
+ mojo_sdk_deps = [
+ "mojo/public/cpp/bindings",
+ "mojo/public/cpp/environment",
+ "mojo/public/cpp/system",
]
}
+# NOTE(vtl): Some of the tests actually depend on a reasonable implementation of
+# the files service (e.g., //services/files).
mojo_native_application("apptests") {
output_name = "mojio_apptests"
@@ -68,14 +81,12 @@ mojo_native_application("apptests") {
deps = [
":mojio",
- "//mojo/public/cpp/application:standalone",
- "//mojo/public/cpp/application:test_support_standalone",
- "//mojo/public/cpp/bindings",
- "//mojo/public/cpp/environment",
- "//mojo/public/cpp/system",
- "//mojo/services/files/public/interfaces",
+ "../interfaces",
+ "$mojo_sdk_root/mojo/public/cpp/application:standalone",
+ "$mojo_sdk_root/mojo/public/cpp/application:test_support_standalone",
+ "$mojo_sdk_root/mojo/public/cpp/bindings",
+ "$mojo_sdk_root/mojo/public/cpp/environment",
+ "$mojo_sdk_root/mojo/public/cpp/system",
"//testing/gtest",
]
-
- data_deps = [ "..:files" ]
}
« no previous file with comments | « mojo/BUILD.gn ('k') | mojo/services/files/public/c/lib/directory_wrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698