Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133863004: Prune some remnants of DSA client certificate support. (Closed)

Created:
5 years, 7 months ago by davidben
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune some remnants of DSA client certificate support. Since the switch to BoringSSL, DSA client certificates are unsupported. BUG=none Committed: https://crrev.com/020819b70399173d40ee098802e647c1cf256b46 Cr-Commit-Position: refs/heads/master@{#329653}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : test server #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -36 lines) Patch
M android_webview/native/aw_contents_client_bridge.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/native/aw_contents_client_bridge_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/android/ssl_client_certificate_request.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/cookies_tree_model_util.cc View 3 chunks +1 line, -15 lines 3 comments Download
M net/ssl/ssl_client_cert_type.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/TestServerBuilder.java View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/testserver/testserver.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
davidben
https://codereview.chromium.org/1133863004/diff/30001/chrome/browser/ui/webui/cookies_tree_model_util.cc File chrome/browser/ui/webui/cookies_tree_model_util.cc (right): https://codereview.chromium.org/1133863004/diff/30001/chrome/browser/ui/webui/cookies_tree_model_util.cc#newcode247 chrome/browser/ui/webui/cookies_tree_model_util.cc:247: l10n_util::GetStringUTF8(IDS_CLIENT_CERT_ECDSA_SIGN)); Is there any reason to localize this? It's ...
5 years, 7 months ago (2015-05-12 00:22:05 UTC) #2
Ryan Sleevi
lgtm https://codereview.chromium.org/1133863004/diff/30001/chrome/browser/ui/webui/cookies_tree_model_util.cc File chrome/browser/ui/webui/cookies_tree_model_util.cc (right): https://codereview.chromium.org/1133863004/diff/30001/chrome/browser/ui/webui/cookies_tree_model_util.cc#newcode247 chrome/browser/ui/webui/cookies_tree_model_util.cc:247: l10n_util::GetStringUTF8(IDS_CLIENT_CERT_ECDSA_SIGN)); On 2015/05/12 00:22:04, David Benjamin wrote: > ...
5 years, 7 months ago (2015-05-12 00:56:12 UTC) #3
davidben
https://codereview.chromium.org/1133863004/diff/30001/chrome/browser/ui/webui/cookies_tree_model_util.cc File chrome/browser/ui/webui/cookies_tree_model_util.cc (right): https://codereview.chromium.org/1133863004/diff/30001/chrome/browser/ui/webui/cookies_tree_model_util.cc#newcode247 chrome/browser/ui/webui/cookies_tree_model_util.cc:247: l10n_util::GetStringUTF8(IDS_CLIENT_CERT_ECDSA_SIGN)); On 2015/05/12 00:56:12, Ryan Sleevi wrote: > On ...
5 years, 7 months ago (2015-05-12 21:31:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133863004/30001
5 years, 7 months ago (2015-05-12 21:31:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/63141)
5 years, 7 months ago (2015-05-12 21:42:14 UTC) #8
davidben
+benm for android_webview +yfriedman for chrome/browser/ui/android/ssl_client_certificate_request.cc +dbeam for chrome/browser/ui/webui/cookies_tree_model_util.cc
5 years, 7 months ago (2015-05-12 21:51:26 UTC) #10
davidben
Switching benm for sgurun since benm's status says inactive.
5 years, 7 months ago (2015-05-12 21:52:08 UTC) #12
sgurun-gerrit only
On 2015/05/12 21:52:08, David Benjamin wrote: > Switching benm for sgurun since benm's status says ...
5 years, 7 months ago (2015-05-12 22:14:59 UTC) #13
Dan Beam
lgtm
5 years, 7 months ago (2015-05-12 23:05:36 UTC) #14
Yaron
lgtm
5 years, 7 months ago (2015-05-13 01:33:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133863004/30001
5 years, 7 months ago (2015-05-13 16:27:52 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:30001)
5 years, 7 months ago (2015-05-13 16:34:58 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 16:36:51 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/020819b70399173d40ee098802e647c1cf256b46
Cr-Commit-Position: refs/heads/master@{#329653}

Powered by Google App Engine
This is Rietveld 408576698