Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7536)

Unified Diff: chrome/browser/ui/webui/cookies_tree_model_util.cc

Issue 1133863004: Prune some remnants of DSA client certificate support. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test server Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/android/ssl_client_certificate_request.cc ('k') | net/ssl/ssl_client_cert_type.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/cookies_tree_model_util.cc
diff --git a/chrome/browser/ui/webui/cookies_tree_model_util.cc b/chrome/browser/ui/webui/cookies_tree_model_util.cc
index ab13500780491fc7ee73fab3ab0a0b85ba64bd21..72bb7a923666163bcd62ea6f19e8f939c7258374 100644
--- a/chrome/browser/ui/webui/cookies_tree_model_util.cc
+++ b/chrome/browser/ui/webui/cookies_tree_model_util.cc
@@ -18,7 +18,6 @@
#include "content/public/browser/indexed_db_context.h"
#include "content/public/browser/service_worker_context.h"
#include "net/cookies/canonical_cookie.h"
-#include "net/ssl/ssl_client_cert_type.h"
#include "storage/common/fileapi/file_system_types.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/text/bytes_formatting.h"
@@ -68,19 +67,6 @@ const char kKeyScopes[] = "scopes";
const int64 kNegligibleUsage = 1024; // 1KiB
-std::string ClientCertTypeToString(net::SSLClientCertType type) {
- switch (type) {
- case net::CLIENT_CERT_RSA_SIGN:
- return l10n_util::GetStringUTF8(IDS_CLIENT_CERT_RSA_SIGN);
- case net::CLIENT_CERT_DSS_SIGN:
- return l10n_util::GetStringUTF8(IDS_CLIENT_CERT_DSS_SIGN);
- case net::CLIENT_CERT_ECDSA_SIGN:
- return l10n_util::GetStringUTF8(IDS_CLIENT_CERT_ECDSA_SIGN);
- default:
- return base::IntToString(type);
- }
-}
-
} // namespace
CookiesTreeModelUtil::CookiesTreeModelUtil() {
@@ -258,7 +244,7 @@ bool CookiesTreeModelUtil::GetCookieTreeNodeDictionary(
dict->SetString(kKeyServerId, channel_id.server_identifier());
dict->SetString(kKeyCertType,
- ClientCertTypeToString(net::CLIENT_CERT_ECDSA_SIGN));
+ l10n_util::GetStringUTF8(IDS_CLIENT_CERT_ECDSA_SIGN));
davidben 2015/05/12 00:22:04 Is there any reason to localize this? It's the str
Ryan Sleevi 2015/05/12 00:56:12 No clue. I suspect maybe they wanted to say "Ellip
davidben 2015/05/12 21:31:01 Looks like it's got translateable="false" anyway,
dict->SetString(kKeyCreated, base::UTF16ToUTF8(
base::TimeFormatFriendlyDateAndTime(
channel_id.creation_time())));
« no previous file with comments | « chrome/browser/ui/android/ssl_client_certificate_request.cc ('k') | net/ssl/ssl_client_cert_type.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698