Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: net/sdch/sdch_owner_unittest.cc

Issue 1133763003: SdchObserver: add OnDictionary{Added,Removed} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove manager parameter from SdchObserver Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/net/sdch_browsertest.cc ('K') | « net/sdch/sdch_owner.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/sdch/sdch_owner_unittest.cc
diff --git a/net/sdch/sdch_owner_unittest.cc b/net/sdch/sdch_owner_unittest.cc
index e522d18614f57ffe19ea1313e69e0b410b4a39e7..788a9929b6f39e9760a4aa835013553aa214df92 100644
--- a/net/sdch/sdch_owner_unittest.cc
+++ b/net/sdch/sdch_owner_unittest.cc
@@ -299,7 +299,7 @@ class SdchOwnerTest : public testing::Test {
}
void SignalGetDictionaryAndClearJobs(GURL request_url, GURL dictionary_url) {
- sdch_owner().OnGetDictionary(&sdch_manager_, request_url, dictionary_url);
+ sdch_owner().OnGetDictionary(request_url, dictionary_url);
WaitForNoJobs();
}
@@ -561,7 +561,7 @@ TEST_F(SdchOwnerTest, UseChangesEviction) {
EXPECT_TRUE(DictionaryPresentInManager(server_hash_d3));
// Use the oldest dictionary.
- sdch_owner().OnDictionaryUsed(&sdch_manager(), server_hash_d3);
+ sdch_owner().OnDictionaryUsed(server_hash_d3);
// The addition of a new dictionary should succeed, evicting only the
// newer stale one.
@@ -600,8 +600,8 @@ TEST_F(SdchOwnerTest, UsePreventsAddition) {
EXPECT_TRUE(DictionaryPresentInManager(server_hash_d3));
// Use the older dictionaries.
- sdch_owner().OnDictionaryUsed(&sdch_manager(), server_hash_d2);
- sdch_owner().OnDictionaryUsed(&sdch_manager(), server_hash_d3);
+ sdch_owner().OnDictionaryUsed(server_hash_d2);
+ sdch_owner().OnDictionaryUsed(server_hash_d3);
// The addition of a new dictionary should fail, not evicting anything.
std::string server_hash_d4;
@@ -871,7 +871,7 @@ TEST_F(SdchOwnerPersistenceTest, UsingDictionaryUpdatesUseCount) {
ResetOwner(false);
ASSERT_TRUE(CompleteLoadFromURL(url, "0", true));
- owner_->OnDictionaryUsed(manager_.get(), hash);
+ owner_->OnDictionaryUsed(hash);
int new_count;
{
« chrome/browser/net/sdch_browsertest.cc ('K') | « net/sdch/sdch_owner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698