Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: net/sdch/sdch_owner.cc

Issue 1133763003: SdchObserver: add OnDictionary{Added,Removed} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove manager parameter from SdchObserver Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/sdch/sdch_owner.cc
diff --git a/net/sdch/sdch_owner.cc b/net/sdch/sdch_owner.cc
index 226604af5f95396f63a968c5af12b8b7fc0db915..a3ef30ec85361be36de26ec05695b0bede93a8a1 100644
--- a/net/sdch/sdch_owner.cc
+++ b/net/sdch/sdch_owner.cc
@@ -484,8 +484,12 @@ void SdchOwner::OnDictionaryFetched(base::Time last_used,
load_times_[server_hash] = clock_->Now();
}
-void SdchOwner::OnDictionaryUsed(SdchManager* manager,
- const std::string& server_hash) {
+void SdchOwner::OnDictionaryAdded(const GURL& dictionary_url,
+ const std::string& server_hash) { }
+
+void SdchOwner::OnDictionaryRemoved(const std::string& server_hash) { }
+
+void SdchOwner::OnDictionaryUsed(const std::string& server_hash) {
base::Time now(clock_->Now());
base::DictionaryValue* pref_dictionary_map =
GetPersistentStoreDictionaryMap(pref_store_);
@@ -538,8 +542,7 @@ void SdchOwner::OnDictionaryUsed(SdchManager* manager,
specific_dictionary_map->SetInteger(kDictionaryUseCountKey, use_count + 1);
}
-void SdchOwner::OnGetDictionary(SdchManager* manager,
- const GURL& request_url,
+void SdchOwner::OnGetDictionary(const GURL& request_url,
const GURL& dictionary_url) {
#if defined(OS_CHROMEOS)
// For debugging http://crbug.com/454198; remove when resolved.
@@ -581,7 +584,7 @@ void SdchOwner::OnGetDictionary(SdchManager* manager,
base::Unretained(this), base::Time(), 0));
}
-void SdchOwner::OnClearDictionaries(SdchManager* manager) {
+void SdchOwner::OnClearDictionaries() {
total_dictionary_bytes_ = 0;
fetcher_->Cancel();

Powered by Google App Engine
This is Rietveld 408576698