net/base/sdch_manager_unittest.cc - Issue 1133763003: SdchObserver: add OnDictionary{Added,Removed}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/sdch_manager_unittest.cc

Issue 1133763003: SdchObserver: add OnDictionary{Added,Removed} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/sdch_manager_unittest.cc

diff --git a/net/base/sdch_manager_unittest.cc b/net/base/sdch_manager_unittest.cc

index ba3248e3de8601c3b5701b4ac21c4376a55fb4df..7d3e0cd87fcbfb4995187a75f7a4e06640df1996 100644

--- a/net/base/sdch_manager_unittest.cc

+++ b/net/base/sdch_manager_unittest.cc

@@ -50,6 +50,11 @@ class MockSdchObserver : public SdchObserver {

}

// SdchObserver implementation

+ void OnDictionaryAdded(SdchManager* /* manager */,

+ const GURL& /* dictionary_url */,

+ const std::string& /* server_hash */) override {}

+ void OnDictionaryRemoved(SdchManager* /* manager */,

+ const std::string& /* server_hash */) override {}

mmenke 2015/05/12 15:46:42 Should have at least a minimal test for these meth

void OnDictionaryUsed(SdchManager* manager,

const std::string& server_hash) override {

last_server_hash_ = server_hash;