SdchObserver: add OnDictionary{Added,Removed}

net/base/sdch_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <limits.h>
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 32 matching lines @@
   const GURL& last_dictionary_url() const { return last_dictionary_url_; }
   int get_dictionary_notifications() const {
     return get_dictionary_notifications_;
   }
 
   int clear_dictionary_notifications() const {
     return clear_dictionaries_notifications_;
   }
 
   // SdchObserver implementation
+  void OnDictionaryAdded(SdchManager* /* manager */,
+                         const GURL& /* dictionary_url */,
+                         const std::string& /* server_hash */) override {}
+  void OnDictionaryRemoved(SdchManager* /* manager */,
+                           const std::string& /* server_hash */) override {}

[mmenke, 2015/05/12 15:46:42]

Should have at least a minimal test for these methods.

   void OnDictionaryUsed(SdchManager* manager,
                         const std::string& server_hash) override {
     last_server_hash_ = server_hash;
     ++dictionary_used_notifications_;
   }
 
   void OnGetDictionary(SdchManager* manager,
                        const GURL& request_url,
                        const GURL& dictionary_url) override {
     ++get_dictionary_notifications_;
@@ skipping 574 matching lines @@
 
   sdch_manager()->RemoveObserver(&observer);
   EXPECT_EQ(1, observer.dictionary_used_notifications());
   EXPECT_EQ("xyzzy", observer.last_server_hash());
   sdch_manager()->OnDictionaryUsed("plugh");
   EXPECT_EQ(1, observer.dictionary_used_notifications());
   EXPECT_EQ("xyzzy", observer.last_server_hash());
 }
 
 }  // namespace net