third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp - Issue 1133713008: [WIP] Migrate hasPendingActivity from ActiveDOMObject to ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp

Issue 1133713008: [WIP] Migrate hasPendingActivity from ActiveDOMObject to ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review Comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp ('K') | « third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp

diff --git a/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp b/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp

index ff536e8f8519f75d5f28303292f26148cf32ebf9..11f6c1892b857c04e921e3e2d6457f5c791c0509 100644

--- a/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp

+++ b/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp

@@ -254,11 +254,11 @@ bool MediaKeys::hasPendingActivity() const

{

// Remain around if there are pending events.

WTF_LOG(Media, "MediaKeys(%p)::hasPendingActivity %s%s%s", this,

- ActiveDOMObject::hasPendingActivity() ? " ActiveDOMObject::hasPendingActivity()" : "",

+ ScriptWrappable::hasPendingActivity() ? " ActiveDOMObject::hasPendingActivity()" : "",

!m_pendingActions.isEmpty() ? " !m_pendingActions.isEmpty()" : "",

m_reservedForMediaElement ? " m_reservedForMediaElement" : "");

- return ActiveDOMObject::hasPendingActivity() || !m_pendingActions.isEmpty() || m_reservedForMediaElement;

+ return ScriptWrappable::hasPendingActivity() || !m_pendingActions.isEmpty() || m_reservedForMediaElement;

}

void MediaKeys::stop()