third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp - Issue 1133713008: [WIP] Migrate hasPendingActivity from ActiveDOMObject to ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

Issue 1133713008: [WIP] Migrate hasPendingActivity from ActiveDOMObject to ScriptWrappable. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Review Comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h ('K') | « third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp ('k') | third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

diff --git a/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp b/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

index 7ce7a1e25bbee4d0b8d054840842f8dc41271571..79d84cc765845fb58783d94ad702fa38c9368f14 100644

--- a/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

+++ b/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

@@ -110,8 +110,8 @@ bool ContextLifecycleNotifier::hasPendingActivity() const

for (ContextLifecycleObserver* observer : m_observers) {

if (observer->observerType() != ContextLifecycleObserver::ActiveDOMObjectType)

continue;

- ActiveDOMObject* activeDOMObject = static_cast<ActiveDOMObject*>(observer);

- if (activeDOMObject->hasPendingActivity())

+ // ActiveDOMObject* activeDOMObject = static_cast<ActiveDOMObject*>(observer);

+ // if (activeDOMObject->hasPendingActivity())

yurys 2015/10/29 16:28:26 Revert this?

return true;

}

return false;