A Speculative Revert for 164872 - Enable force-compositing-mode on developer and continuous builds.…

A Speculative Revert for 164872 - Enable force-compositing-mode on developer and continuous builds. This should start running the
page-cyclers with FCM.


BUG=152355
Review URL: https://chromiumcodereview.appspot.com/11337014

TBR=vangelis@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164888

[Hironori Bono, 2012-10-30 10:59:03]

Greetings,

Sorry for reverting your change. I would like to try a speculative revert to fix
browser_tests failures, interative_ui_tests failures, and sync_integration_tests
failures on Win bots and Mac bots. (These bots may not support the compositing
mode.) I will re-land your change when this revert does not help fixing the
tests. 

*
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/bui...
*
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/buil...
*
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...
*
http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/b...
* http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Sync/builds/24132
*
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg...
*
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg...
etc.

Regards,

Hironori Bono

[Hironori Bono, 2012-10-30 11:29:22]

Greetings,

It seems failing tests are cycling green after reverting your change (*1). Is it
possible to disable the compositing mode on browser_tests, e.g. adding a
'--disable-force-compositing-mode' option to the BrowserTestBase::SetUp
function?

(*1)
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/b...

Regards,

Hironori Bono

[vangelis, 2012-10-30 16:51:00]

Hi Hironori,
  Let me have a look at the failures.  The trybots were happy with the
change but it is possible that it made some tests flaky...

Thanks,
Vangelis



On Tue, Oct 30, 2012 at 4:29 AM, <hbono@chromium.org> wrote:

> Greetings,
>
> It seems failing tests are cycling green after reverting your change (*1).
> Is it
> possible to disable the compositing mode on browser_tests, e.g. adding a
> '--disable-force-compositing-**mode' option to the BrowserTestBase::SetUp
> function?
>
> (*1)
> http://build.chromium.org/p/**chromium.mac/builders/Mac10.6%**
>
20Tests%20%281%29/builds/31314<http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/31314>
>
>
> Regards,
>
> Hironori Bono
>
>
>
https://codereview.chromium.**org/11337020/<https://codereview.chromium.org/1...
>