Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: lib/src/checker/resolver.dart

Issue 1133663006: Promote analyzer warnings to ddc errors (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/checker/resolver.dart
diff --git a/lib/src/checker/resolver.dart b/lib/src/checker/resolver.dart
index 6af5659330ab0f5c3a426b0e02c02fb852c5da20..5c29d47cd1c1f432585a41ec9129e5a7bdb2e151 100644
--- a/lib/src/checker/resolver.dart
+++ b/lib/src/checker/resolver.dart
@@ -111,7 +111,7 @@ class TypeResolver {
class AnalyzerError extends Message {
factory AnalyzerError.from(analyzer.AnalysisError error) {
var severity = error.errorCode.type.severity;
- var isError = severity == analyzer.ErrorSeverity.ERROR;
+ var isError = severity == analyzer.ErrorSeverity.WARNING;
var level = isError ? logger.Level.SEVERE : logger.Level.WARNING;
int begin = error.offset;
int end = begin + error.length;
@@ -119,7 +119,7 @@ class AnalyzerError extends Message {
}
const AnalyzerError(String message, logger.Level level, int begin, int end)
- : super('[from analyzer]: $message', level, begin, end);
+ : super(message, level, begin, end);
}
/// Creates an analysis context that contains our restricted typing rules.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698