Promote analyzer warnings to ddc errors

lib/src/checker/resolver.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Encapsulates how to invoke the analyzer resolver and overrides how it
 /// computes types on expressions to use our restricted set of types.
 library dev_compiler.src.checker.resolver;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/src/generated/ast.dart';
@@ skipping 93 matching lines @@
         reporter.log(message);
       }
     }
     return failure;
   }
 }
 
 class AnalyzerError extends Message {
   factory AnalyzerError.from(analyzer.AnalysisError error) {
     var severity = error.errorCode.type.severity;
-    var isError = severity == analyzer.ErrorSeverity.ERROR;
+    var isError = severity == analyzer.ErrorSeverity.WARNING;
     var level = isError ? logger.Level.SEVERE : logger.Level.WARNING;
     int begin = error.offset;
     int end = begin + error.length;
     return new AnalyzerError(error.message, level, begin, end);
   }
 
   const AnalyzerError(String message, logger.Level level, int begin, int end)
-      : super('[from analyzer]: $message', level, begin, end);
+      : super(message, level, begin, end);
 }
 
 /// Creates an analysis context that contains our restricted typing rules.
 InternalAnalysisContext _initContext(ResolverOptions options) {
   var analysisOptions = new AnalysisOptionsImpl()..cacheSize = 512;
   AnalysisContextImpl res = AnalysisEngine.instance.createAnalysisContext();
   res.analysisOptions = analysisOptions;
   res.libraryResolverFactory =
       (context) => new LibraryResolverWithInference(context, options);
   return res;
@@ skipping 655 matching lines @@
     }
   }
 
   // Review note: no longer need to override visitFunctionExpression, this is
   // handled by the analyzer internally.
   // TODO(vsm): in visitbinaryExpression: check computeStaticReturnType result?
   // TODO(vsm): in visitFunctionDeclaration: Should we ever use the expression
   // type in a (...) => expr or just the written type?
 
 }