Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1133663006: Promote analyzer warnings to ddc errors (Closed)

Created:
5 years, 7 months ago by vsm
Modified:
5 years, 7 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org, Brian Wilkerson
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Promote analyzer warnings to ddc errors This is perhaps a blunt hammer, but every warning i'm hitting in angular so far should be an error in ddc. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/2554a63fa42bc949a64e7e69ed4ab4a56b8c29b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/src/checker/resolver.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
vsm
5 years, 7 months ago (2015-05-15 16:40:24 UTC) #2
Leaf
lgtm
5 years, 7 months ago (2015-05-15 16:41:48 UTC) #3
vsm
5 years, 7 months ago (2015-05-15 16:47:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2554a63fa42bc949a64e7e69ed4ab4a56b8c29b3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698