PPAPI: Add new PPB_FileRef.MakeDirectory to support exclusive operation

ppapi/cpp/file_ref.h

Index: ppapi/cpp/file_ref.h
diff --git a/ppapi/cpp/file_ref.h b/ppapi/cpp/file_ref.h
index 452d2a61321866ba44ec2f70d3cf6b9db78417eb..0b34d5f6334b3964b0d667bfb81ea9c0c703b137 100644
--- a/ppapi/cpp/file_ref.h
+++ b/ppapi/cpp/file_ref.h
@@ -90,30 +90,26 @@ class FileRef : public Resource {
   /// <code>PP_FileSystemType_External</code>.
   FileRef GetParent() const;
 
-  /// MakeDirectory() makes a new directory in the file system.  It is not
-  /// valid to make a directory in the external file system.
-  /// <strong>Note:</strong> Use MakeDirectoryIncludingAncestors() to create
-  /// parent directories.
-  ///
-  /// @param[in] cc A <code>CompletionCallback</code> to be called upon
-  /// completion of MakeDirectory().
-  ///
-  /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
-  /// Succeeds if the directory already exists. Fails if ancestor
-  /// directortories do not exist (see MakeDirectoryIncludingAncestors for the
-  /// alternative).
-  int32_t MakeDirectory(const CompletionCallback& cc);
-
-  /// MakeDirectoryIncludingAncestors() makes a new directory in the file
-  /// system as well as any parent directories. It is not valid to make a
+  /// MakeDirectory() makes a new directory in the file system according to the
+  /// given <code>make_directory_flags</code>, which is a bit-mask of the
+  /// <code>PP_MakeDirectoryFlags</code> values.  It is not valid to make a
   /// directory in the external file system.
   ///
+  /// @param[in] exclusive A <code>bool</code> set to <code>true</code> to fail

[yzshen1, 2014/01/07 17:59:23]

Please remove this @param

[nhiroki, 2014/01/08 06:12:33]

Done.

+  /// if the directory already exists.
+  /// @param[in] make_directory_flags A bit-mask of the
+  /// <code>PP_MakeDirectoryFlags</code> values.  Valid values are:

[yzshen1, 2014/01/07 17:59:23]

it seems unnecessary to list valid values here. readers can refer to the
definition of PP_MakeDirectoryFlags, right?

[nhiroki, 2014/01/08 06:12:33]

Done.

+  ///  - PP_MAKEDIRECTORYFLAG_NONE
+  ///  - PP_MAKEDIRECTORYFLAG_WITH_ANCESTORS
+  ///  - PP_MAKEDIRECTORYFLAG_EXCLUSIVE
+  /// See <code>PP_MakeDirectoryFlags</code> in <code>ppb_file_ref.h</code> for
+  /// more details on these flags.
   /// @param[in] cc A <code>CompletionCallback</code> to be called upon
-  /// completion of MakeDirectoryIncludingAncestors().
+  /// completion of MakeDirectory().
   ///
   /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
-  /// Succeeds if the directory already exists.
-  int32_t MakeDirectoryIncludingAncestors(const CompletionCallback& cc);
+  int32_t MakeDirectory(int32_t make_directory_flags,
+                        const CompletionCallback& cc);
 
   /// Touch() Updates time stamps for a file.  You must have write access to the
   /// file if it exists in the external filesystem.