PPAPI: Add new PPB_FileRef.MakeDirectory to support exclusive operation

ppapi/cpp/file_ref.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_CPP_FILE_REF_H_
 #define PPAPI_CPP_FILE_REF_H_
 
 #include "ppapi/c/pp_file_info.h"
 #include "ppapi/c/pp_stdint.h"
 #include "ppapi/c/ppb_file_ref.h"
@@ skipping 72 matching lines @@
 
   /// GetParent() returns the parent directory of this file.  If
   /// <code>file_ref</code> points to the root of the filesystem, then the root
   /// is returned.
   ///
   /// @return A <code>FileRef</code> containing the parent directory of the
   /// file. This function fails if the file system type is
   /// <code>PP_FileSystemType_External</code>.
   FileRef GetParent() const;
 
-  /// MakeDirectory() makes a new directory in the file system.  It is not
-  /// valid to make a directory in the external file system.
-  /// <strong>Note:</strong> Use MakeDirectoryIncludingAncestors() to create
-  /// parent directories.
+  /// MakeDirectory() makes a new directory in the file system according to the
+  /// given <code>make_directory_flags</code>, which is a bit-mask of the
+  /// <code>PP_MakeDirectoryFlags</code> values.  It is not valid to make a
+  /// directory in the external file system.
   ///
+  /// @param[in] exclusive A <code>bool</code> set to <code>true</code> to fail

[yzshen1, 2014/01/07 17:59:23]

Please remove this @param

[nhiroki, 2014/01/08 06:12:33]

Done.

+  /// if the directory already exists.
+  /// @param[in] make_directory_flags A bit-mask of the
+  /// <code>PP_MakeDirectoryFlags</code> values.  Valid values are:

[yzshen1, 2014/01/07 17:59:23]

it seems unnecessary to list valid values here. readers can refer to the
definition of PP_MakeDirectoryFlags, right?

[nhiroki, 2014/01/08 06:12:33]

Done.

+  ///  - PP_MAKEDIRECTORYFLAG_NONE
+  ///  - PP_MAKEDIRECTORYFLAG_WITH_ANCESTORS
+  ///  - PP_MAKEDIRECTORYFLAG_EXCLUSIVE
+  /// See <code>PP_MakeDirectoryFlags</code> in <code>ppb_file_ref.h</code> for
+  /// more details on these flags.
   /// @param[in] cc A <code>CompletionCallback</code> to be called upon
   /// completion of MakeDirectory().
   ///
   /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
-  /// Succeeds if the directory already exists. Fails if ancestor
-  /// directortories do not exist (see MakeDirectoryIncludingAncestors for the
-  /// alternative).
-  int32_t MakeDirectory(const CompletionCallback& cc);
-
-  /// MakeDirectoryIncludingAncestors() makes a new directory in the file
-  /// system as well as any parent directories. It is not valid to make a
-  /// directory in the external file system.
-  ///
-  /// @param[in] cc A <code>CompletionCallback</code> to be called upon
-  /// completion of MakeDirectoryIncludingAncestors().
-  ///
-  /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
-  /// Succeeds if the directory already exists.
-  int32_t MakeDirectoryIncludingAncestors(const CompletionCallback& cc);
+  int32_t MakeDirectory(int32_t make_directory_flags,
+                        const CompletionCallback& cc);
 
   /// Touch() Updates time stamps for a file.  You must have write access to the
   /// file if it exists in the external filesystem.
   ///
   /// @param[in] last_access_time The last time the file was accessed.
   /// @param[in] last_modified_time The last time the file was modified.
   /// @param[in] cc A <code>CompletionCallback</code> to be called upon
   /// completion of Touch().
   ///
   /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
@@ skipping 55 matching lines @@
   ///
   /// @return An int32_t containing an error code from <code>pp_errors.h</code>.
   int32_t ReadDirectoryEntries(
       const CompletionCallbackWithOutput< std::vector<DirectoryEntry> >&
           callback);
 };
 
 }  // namespace pp
 
 #endif  // PPAPI_CPP_FILE_REF_H_