Move password_manager_util and password_bubble_experiment to components

Move password_manager_util and password_bubble_experiment to components

BUG=486739
Committed: https://crrev.com/205d8da3ff51ec789abcef187191b9a82519b9b2
Cr-Commit-Position: refs/heads/master@{#330905}

[vabr (Chromium), 2015-05-19 17:06:24]

Patchset #1 (id:1) has been deleted

[vabr (Chromium), 2015-05-19 17:12:41]

vabr@chromium.org changed reviewers:
+ isherman@chromium.org, mkwst@chromium.org, newt@chromium.org,
stevenjb@chromium.org

[vabr (Chromium), 2015-05-19 17:12:42]

Hi all,

newt, isherman, stevenjb, please do OWNERS rubberstamps for renamed #includes:

newt -- chrome/browser/android/password_ui_view_android.cc
isherman --
chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
stevenjb -- chrome/browser/ui/webui/options/*


Mike, please review the whole CL. It is only moving files + 2 comment changes
flagged below.

Sorry, no trybots yet, this depends on
https://codereview.chromium.org/1141413002/.

Thanks!
Vaclav

https://codereview.chromium.org/1133613007/diff/20001/components/password_man...
File components/password_manager/core/browser/password_bubble_experiment.cc
(right):

https://codereview.chromium.org/1133613007/diff/20001/components/password_man...
components/password_manager/core/browser/password_bubble_experiment.cc:17: }  //
namespace
Target directory has clang format enforcing, therefore changing on move.

https://codereview.chromium.org/1133613007/diff/20001/components/password_man...
components/password_manager/core/browser/password_bubble_experiment.cc:22: //
TODO(vasilii): store the statistics and consider merging with
Flagging another non-move change: enhanced TODO comment. :)

[newt (away), 2015-05-19 18:01:12]

password_ui_view_android.cc lgtm

[Ilya Sherman, 2015-05-19 22:56:07]

chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc lgtm. 
For future reference, this sort of change is appropriate to TBR for files where
you're just updating include paths, IMO.

[vabr (Chromium), 2015-05-20 07:15:30]

vabr@chromium.org changed reviewers:
+ estade@chromium.org

[vabr (Chromium), 2015-05-20 07:15:30]

Steven appears to be OOO, Evan could you review
chrome/browser/ui/webui/options/*?

As Ilya points out, the #include changes seem OK to TBR [1], so no rush, Evan, I
will TBR you if needed (this CL is blocked on another one, though).

Thanks!
Vaclav

[1]
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...

[Evan Stade, 2015-05-20 21:14:44]

chrome/browser/ui/webui/options/* lgtm

you can tbr when all you're doing is updating include paths

[Evan Stade, 2015-05-20 21:15:23]

On 2015/05/20 21:14:44, Evan Stade wrote:
> chrome/browser/ui/webui/options/* lgtm
> 
> you can tbr when all you're doing is updating include paths

I see you already decided this. I should read more.

[vabr (Chromium), 2015-05-20 21:29:57]

On 2015/05/20 21:15:23, Evan Stade wrote:
> On 2015/05/20 21:14:44, Evan Stade wrote:
> > chrome/browser/ui/webui/options/* lgtm
> > 
> > you can tbr when all you're doing is updating include paths
> 
> I see you already decided this. I should read more.

I wrote too much, it got lost. :)
Thanks for the review, Evan!

[vabr (Chromium), 2015-05-20 21:30:09]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2015-05-20 21:31:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133613007/20001

[commit-bot: I haz the power, 2015-05-20 21:42:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-20 21:42:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[vabr (Chromium), 2015-05-20 21:47:21]

vabr@chromium.org changed reviewers:
+ zea@chromium.org

[vabr (Chromium), 2015-05-20 21:47:21]

zea@, could you please review
components/password_manager/core/browser/DEPS ?

Thanks!
Vaclav

[vabr (Chromium), 2015-05-20 21:58:02]

vabr@chromium.org changed reviewers:
+ stanisc@chromium.org

[vabr (Chromium), 2015-05-20 21:58:02]

Actually, given zea@'s calendar:
stanisc@, could you please review  components/password_manager/core/browser/DEPS
?

Thank you!
Vaclav

[stanisc, 2015-05-21 00:46:21]

I am not an owner for components/password_manager/core/browser/DEPS but it looks
like this file is already covered by someone else.

[Ilya Sherman, 2015-05-21 02:57:10]

On 2015/05/21 00:46:21, stanisc wrote:
> I am not an owner for components/password_manager/core/browser/DEPS but it
looks
> like this file is already covered by someone else.

When a new dependency is added, an owner of the depended-on thing needs to
approve the dependency.  So, in this case, Václav is asking you to approve the
dependency on //components/sync_driver =)

[stanisc, 2015-05-21 03:57:58]

On 2015/05/21 02:57:10, Ilya Sherman wrote:
> On 2015/05/21 00:46:21, stanisc wrote:
> > I am not an owner for components/password_manager/core/browser/DEPS but it
> looks
> > like this file is already covered by someone else.
> 
> When a new dependency is added, an owner of the depended-on thing needs to
> approve the dependency.  So, in this case, Václav is asking you to approve the
> dependency on //components/sync_driver =)

I see. LGTM

[vabr (Chromium), 2015-05-21 06:11:58]

On 2015/05/21 03:57:58, stanisc wrote:
> On 2015/05/21 02:57:10, Ilya Sherman wrote:
> > On 2015/05/21 00:46:21, stanisc wrote:
> > > I am not an owner for components/password_manager/core/browser/DEPS but it
> > looks
> > > like this file is already covered by someone else.
> > 
> > When a new dependency is added, an owner of the depended-on thing needs to
> > approve the dependency.  So, in this case, Václav is asking you to approve
the
> > dependency on //components/sync_driver =)
> 
> I see. LGTM

I should have been clearer on that, sorry!
And thanks stanisc@ for the approval, and Ilya for the explanation! :)
Sending to the CQ again.
Vaclav

[vabr (Chromium), 2015-05-21 06:12:06]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2015-05-21 06:12:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133613007/20001

[commit-bot: I haz the power, 2015-05-21 06:17:24]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2015-05-21 06:18:19]

Patchset 1 (id:??) landed as
https://crrev.com/205d8da3ff51ec789abcef187191b9a82519b9b2
Cr-Commit-Position: refs/heads/master@{#330905}