Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: components/password_manager/core/browser/password_bubble_experiment.cc

Issue 1133613007: Move password_manager_util and password_bubble_experiment to components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@486739_componentise_experiment_utils_to_ios_sources
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_bubble_experiment.cc
diff --git a/chrome/browser/ui/passwords/password_bubble_experiment.cc b/components/password_manager/core/browser/password_bubble_experiment.cc
similarity index 76%
rename from chrome/browser/ui/passwords/password_bubble_experiment.cc
rename to components/password_manager/core/browser/password_bubble_experiment.cc
index 50ec27f2c10cf071d9679c3b7d104650ec4d787e..a03d90b216194073f6286b45e41b41f7574a283d 100644
--- a/chrome/browser/ui/passwords/password_bubble_experiment.cc
+++ b/components/password_manager/core/browser/password_bubble_experiment.cc
@@ -2,11 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/passwords/password_bubble_experiment.h"
+#include "components/password_manager/core/browser/password_bubble_experiment.h"
#include "base/metrics/field_trial.h"
#include "base/prefs/pref_service.h"
-#include "chrome/browser/password_manager/password_manager_util.h"
+#include "components/password_manager/core/browser/password_manager_util.h"
namespace password_bubble_experiment {
namespace {
@@ -14,12 +14,13 @@ namespace {
const char kBrandingExperimentName[] = "PasswordBranding";
const char kSmartLockBrandingGroupName[] = "SmartLockBranding";
-} // namespace
+} // namespace
vabr (Chromium) 2015/05/19 17:12:42 Target directory has clang format enforcing, there
void RecordBubbleClosed(
PrefService* prefs,
password_manager::metrics_util::UIDismissalReason reason) {
- // TODO(vasilii): store the statistics.
+ // TODO(vasilii): store the statistics and consider merging with
vabr (Chromium) 2015/05/19 17:12:41 Flagging another non-move change: enhanced TODO co
+ // password_manager_metrics_util.*.
}
bool IsSmartLockBrandingEnabled(const sync_driver::SyncService* sync_service) {

Powered by Google App Engine
This is Rietveld 408576698