Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1133543003: Clean up app list webstore_provider_browsertest. (Closed)

Created:
5 years, 7 months ago by Matt Giuca
Modified:
5 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up app list webstore_provider_browsertest. Record whether a query is pending and use it to decide when to wait (previously, it would wait if ANY previous query was ever pending, which "just happened" to work for the specific test cases). Changed some ASSERT into EXPECT. Use more descriptive special strings for HTTP errors, rather than the exact same string as the query, which is confusing. Document the test cases properly. Reformat the source according to ClangFormat. BUG=481837 Committed: https://crrev.com/a44e9ca99fb9450a40d015723d23625fd3dff218 Cr-Commit-Position: refs/heads/master@{#329327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -67 lines) Patch
M chrome/browser/ui/app_list/search/webstore/webstore_provider.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider_browsertest.cc View 7 chunks +89 lines, -65 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Matt Giuca
This is a precursor to https://codereview.chromium.org/1110903002. There was so much stuff to fix in this ...
5 years, 7 months ago (2015-05-08 04:55:29 UTC) #2
calamity
Reformat the CL description to have bullet points and make all points have the same ...
5 years, 7 months ago (2015-05-11 06:00:21 UTC) #3
calamity
lgtm
5 years, 7 months ago (2015-05-11 06:28:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133543003/1
5 years, 7 months ago (2015-05-12 01:30:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 02:24:55 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 02:25:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a44e9ca99fb9450a40d015723d23625fd3dff218
Cr-Commit-Position: refs/heads/master@{#329327}

Powered by Google App Engine
This is Rietveld 408576698