App Launcher: Webstore results are now ranked by title match.

App Launcher: Webstore results are now ranked by title match.

Previously, all Webstore results had an internal relevance score of 0.0.
Now they are scored based on the query matched against the app's title,
and scores of 0.0 are discarded. This fixes app results showing up
because the word you typed appears in the app's web store description,
but not its title.

BUG=481837
Committed: https://crrev.com/4872ba41d2be74386a21897636c7d64a698cc97b
Cr-Commit-Position: refs/heads/master@{#329343}

[Matt Giuca, 2015-04-28 08:01:02]

Patchset #2 (id:20001) has been deleted

[Matt Giuca, 2015-04-28 08:09:44]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2015-04-29 05:33:16]

lgtm.

https://codereview.chromium.org/1110903002/diff/70001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/search/webstore/webstore_provider.cc (right):

https://codereview.chromium.org/1110903002/diff/70001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/search/webstore/webstore_provider.cc:185: return
result.Pass();
I can see that it's the pattern here, but this is weird. Can we just return
scoped_ptr<SearchResult>() for each of the early returns and a
make_scoped_ptr(new WebstoreResult(...)) at the end?

[Matt Giuca, 2015-04-29 05:46:30]

https://codereview.chromium.org/1110903002/diff/70001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/search/webstore/webstore_provider.cc (right):

https://codereview.chromium.org/1110903002/diff/70001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/search/webstore/webstore_provider.cc:185: return
result.Pass();
Yes.

[Matt Giuca, 2015-04-29 05:46:53]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-04-29 05:46:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/1110903002/#ps90001
(title: "Fix use of scoped_ptr.")

[commit-bot: I haz the power, 2015-04-29 05:48:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110903002/90001

[commit-bot: I haz the power, 2015-04-29 07:08:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-29 07:08:36]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2015-05-08 05:09:58]

PTAL (browser_tests). Also, note that this is now based off of
https://codereview.chromium.org/1133543003/ which I also sent to you.

[calamity, 2015-05-11 06:34:25]

slgtm.

[Matt Giuca, 2015-05-12 01:27:19]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-05-12 01:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/1110903002/#ps150001
(title: "NULL -> nullptr.")

[Matt Giuca, 2015-05-12 01:27:32]

The CQ bit was unchecked by mgiuca@chromium.org

[Matt Giuca, 2015-05-12 01:28:41]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-05-12 01:28:43]

The CQ bit was unchecked by mgiuca@chromium.org

[Matt Giuca, 2015-05-12 02:57:24]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-05-12 02:58:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1110903002/150001

[commit-bot: I haz the power, 2015-05-12 03:46:30]

Committed patchset #8 (id:150001)

[commit-bot: I haz the power, 2015-05-12 03:47:24]

Patchset 8 (id:??) landed as
https://crrev.com/4872ba41d2be74386a21897636c7d64a698cc97b
Cr-Commit-Position: refs/heads/master@{#329343}