Omnibox - Log Addition Crash Data for Rare HQP Crash

chrome/common/crash_keys.cc

Index: chrome/common/crash_keys.cc
diff --git a/chrome/common/crash_keys.cc b/chrome/common/crash_keys.cc
index ceb9c013a39d3a60093ff73b0bf582d821d768f0..57007e0b3c9714994564ece4b11b40d0c5c0a6c7 100644
--- a/chrome/common/crash_keys.cc
+++ b/chrome/common/crash_keys.cc
@@ -128,6 +128,8 @@ const char kKaskoGuid[] = "kasko-guid";
 const char kKaskoEquivalentGuid[] = "kasko-equivalent-guid";
 #endif
 
+const char kBug464926CrashKey[] = "bug-464926-info";
+
 size_t RegisterChromeCrashKeys() {
   // The following keys may be chunked by the underlying crash logging system,
   // but ultimately constitute a single key-value pair.
@@ -243,6 +245,12 @@ size_t RegisterChromeCrashKeys() {
     }
   }
 
+  // Register a key to help investigate bug 464926.

[Robert Sesek, 2015/05/13 15:22:34]

This should just go in the fixed_keys array.

[Mark P, 2015/05/13 17:50:14]

Okay.  Done.

In the future, you may want to revise the fixed_keys name or comment.  I
intentionally didn't put this key in there because the name fixed_keys made me
think these keys are the ones always uploaded with chrome (on platforms), not
keys that can appear or disappear based on the crash context (i.e., keys that
are not fixed / not consistent / not permanent).

+  {
+    base::debug::CrashKey crash_key = { kBug464926CrashKey, kSmallSize };
+    keys.push_back(crash_key);
+  }
+
   return base::debug::InitCrashKeys(&keys.at(0), keys.size(),
                                     kSingleChunkLength);
 }