Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: ios/chrome/browser/history/history_client_impl.cc

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/history/history_client_impl.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/history/history_client_impl.cc
diff --git a/ios/chrome/browser/history/history_client_impl.cc b/ios/chrome/browser/history/history_client_impl.cc
index bf88bc3d9e99c9ac41d5df7325689f32c7b0632f..780a59dfcc6d2d0ebd66a1e818d5d37b240f767b 100644
--- a/ios/chrome/browser/history/history_client_impl.cc
+++ b/ios/chrome/browser/history/history_client_impl.cc
@@ -27,9 +27,10 @@ void HistoryClientImpl::OnHistoryServiceCreated(
on_bookmarks_removed_ =
base::Bind(&history::HistoryService::URLsNoLongerBookmarked,
base::Unretained(history_service));
- favicon_changed_subscription_ = history_service->AddFaviconChangedCallback(
- base::Bind(&bookmarks::BookmarkModel::OnFaviconChanged,
- base::Unretained(bookmark_model_)));
+ favicons_changed_subscription_ =
+ history_service->AddFaviconsChangedCallback(
+ base::Bind(&bookmarks::BookmarkModel::OnFaviconsChanged,
+ base::Unretained(bookmark_model_)));
bookmark_model_->AddObserver(this);
is_bookmark_model_observer_ = true;
}
@@ -47,7 +48,7 @@ void HistoryClientImpl::Shutdown() {
if (is_bookmark_model_observer_) {
is_bookmark_model_observer_ = false;
bookmark_model_->RemoveObserver(this);
- favicon_changed_subscription_.reset();
+ favicons_changed_subscription_.reset();
on_bookmarks_removed_.Reset();
}
bookmark_model_->Shutdown();
« no previous file with comments | « ios/chrome/browser/history/history_client_impl.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698