ios/chrome/browser/history/history_client_impl.h - Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/history/history_client_impl.h

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/history/core/test/history_backend_db_base_test.cc ('k') | ios/chrome/browser/history/history_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/history/history_client_impl.h

diff --git a/ios/chrome/browser/history/history_client_impl.h b/ios/chrome/browser/history/history_client_impl.h

index 959c50f0221b3ec2afd908844bf4d8fc59e9d375..abcfff3f6b7c32df20575f0742cf4b3c41370397 100644

--- a/ios/chrome/browser/history/history_client_impl.h

+++ b/ios/chrome/browser/history/history_client_impl.h

@@ -57,8 +57,9 @@ class HistoryClientImpl : public history::HistoryClient,

base::Callback<void(const std::set<GURL>&)> on_bookmarks_removed_;

// Subscription for notifications of changes to favicons.

- scoped_ptr<base::CallbackList<void(const std::set<GURL>&)>::Subscription>

- favicon_changed_subscription_;

+ scoped_ptr<base::CallbackList<void(const std::set<GURL>&,

+ const GURL&)>::Subscription>

+ favicons_changed_subscription_;

DISALLOW_COPY_AND_ASSIGN(HistoryClientImpl);

};

« no previous file with comments | « components/history/core/test/history_backend_db_base_test.cc ('k') | ios/chrome/browser/history/history_client_impl.cc » ('j') | no next file with comments »