Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: chrome/browser/sync/sessions/notification_service_sessions_router.cc

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sessions/notification_service_sessions_router.cc
diff --git a/chrome/browser/sync/sessions/notification_service_sessions_router.cc b/chrome/browser/sync/sessions/notification_service_sessions_router.cc
index fd27c12d5f8003ae420e5272bdcdec30cdf0ce3f..f685a92d725a4815a212523168c003f97d66965b 100644
--- a/chrome/browser/sync/sessions/notification_service_sessions_router.cc
+++ b/chrome/browser/sync/sessions/notification_service_sessions_router.cc
@@ -61,8 +61,8 @@ NotificationServiceSessionsRouter::NotificationServiceSessionsRouter(
HistoryServiceFactory::GetForProfile(profile,
ServiceAccessType::EXPLICIT_ACCESS);
if (history_service) {
- favicon_changed_subscription_ = history_service->AddFaviconChangedCallback(
- base::Bind(&NotificationServiceSessionsRouter::OnFaviconChanged,
+ favicon_changed_subscription_ = history_service->AddFaviconsChangedCallback(
+ base::Bind(&NotificationServiceSessionsRouter::OnFaviconsChanged,
base::Unretained(this)));
}
#if defined(ENABLE_SUPERVISED_USERS)
@@ -155,10 +155,11 @@ void NotificationServiceSessionsRouter::OnNavigationBlocked(
handler_->OnLocalTabModified(tab);
}
-void NotificationServiceSessionsRouter::OnFaviconChanged(
- const std::set<GURL>& changed_favicons) {
+void NotificationServiceSessionsRouter::OnFaviconsChanged(
+ const std::set<GURL>& page_urls,
+ const GURL& icon_url) {
if (handler_)
- handler_->OnFaviconPageUrlsUpdated(changed_favicons);
+ handler_->OnFaviconsChanged(page_urls, icon_url);
}
void NotificationServiceSessionsRouter::StartRoutingTo(

Powered by Google App Engine
This is Rietveld 408576698