Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2429)

Unified Diff: chrome/browser/sync/sessions/notification_service_sessions_router.h

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sessions/notification_service_sessions_router.h
diff --git a/chrome/browser/sync/sessions/notification_service_sessions_router.h b/chrome/browser/sync/sessions/notification_service_sessions_router.h
index 81a775cbf5a74db6607cfc61131cc74a985146a9..8d0eb32126c42f4ea610ca45ccd3b0db02c63c43 100644
--- a/chrome/browser/sync/sessions/notification_service_sessions_router.h
+++ b/chrome/browser/sync/sessions/notification_service_sessions_router.h
@@ -51,15 +51,21 @@ class NotificationServiceSessionsRouter
// from WebContents.
void OnNavigationBlocked(content::WebContents* web_contents);
- // Called when the urls of favicon changed.
- void OnFaviconChanged(const std::set<GURL>& changed_favicons);
+ // Called when the favicons for the given page URLs
+ // (e.g. http://www.google.com) and the given icon URL (e.g.
+ // http://www.google.com/favicon.ico) have changed. It is valid to call
+ // OnFaviconsChanged() with non-empty |page_urls| and an empty |icon_url|
+ // and vice versa.
+ void OnFaviconsChanged(const std::set<GURL>& page_urls,
+ const GURL& icon_url);
LocalSessionEventHandler* handler_;
content::NotificationRegistrar registrar_;
Profile* const profile_;
syncer::SyncableService::StartSyncFlare flare_;
- scoped_ptr<base::CallbackList<void(const std::set<GURL>&)>::Subscription>
+ scoped_ptr<base::CallbackList<void(const std::set<GURL>&,
+ const GURL&)>::Subscription>
favicon_changed_subscription_;
base::WeakPtrFactory<NotificationServiceSessionsRouter> weak_ptr_factory_;
« no previous file with comments | « chrome/browser/history/chrome_history_client.cc ('k') | chrome/browser/sync/sessions/notification_service_sessions_router.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698