Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/android/android_provider_backend_unittest.cc
diff --git a/chrome/browser/history/android/android_provider_backend_unittest.cc b/chrome/browser/history/android/android_provider_backend_unittest.cc
index 8795a260fd5dbce07bcc104843586a0df503cfce..72d09bfe0f8bbe947ccd436725af5eec6f2d6470 100644
--- a/chrome/browser/history/android/android_provider_backend_unittest.cc
+++ b/chrome/browser/history/android/android_provider_backend_unittest.cc
@@ -76,8 +76,10 @@ class AndroidProviderBackendDelegate : public HistoryBackend::Delegate {
void NotifyProfileError(sql::InitStatus init_status) override {}
void SetInMemoryBackend(
scoped_ptr<InMemoryHistoryBackend> backend) override {}
- void NotifyFaviconChanged(const std::set<GURL>& url) override {
- favicon_changed_.reset(new std::set<GURL>(url.begin(), url.end()));
+ void NotifyFaviconsChanged(const std::set<GURL>& page_urls,
+ const GURL& icon_url) override {
+ favicon_changed_.reset(
+ new std::set<GURL>(page_urls.begin(), page_urls.end()));
}
void NotifyURLVisited(ui::PageTransition,
const history::URLRow& row,
@@ -123,8 +125,10 @@ class AndroidProviderBackendNotifier : public HistoryBackendNotifier {
AndroidProviderBackendNotifier() {}
// HistoryBackendNotifier:
- void NotifyFaviconChanged(const std::set<GURL>& url) override {
- favicon_changed_.reset(new std::set<GURL>(url.begin(), url.end()));
+ void NotifyFaviconsChanged(const std::set<GURL>& page_urls,
+ const GURL& icon_url) override {
+ favicon_changed_.reset(
+ new std::set<GURL>(page_urls.begin(), page_urls.end()));
}
void NotifyURLVisited(ui::PageTransition,
const history::URLRow& row,
« no previous file with comments | « chrome/browser/history/android/android_provider_backend.cc ('k') | chrome/browser/history/chrome_history_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698