chrome/browser/history/android/android_provider_backend.cc - Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/android_provider_backend.cc

Issue 1133463005: Update all bookmarks which use an icon URL when a favicon's bitmap is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@startup_do_not_unexpire

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/history/android/android_provider_backend.cc

diff --git a/chrome/browser/history/android/android_provider_backend.cc b/chrome/browser/history/android/android_provider_backend.cc

index cfaa8562752bc9000f10fabebec7783bcb9ab2db..96f42e03c67f8eeef88742b902b9e74d76a72c7c 100644

--- a/chrome/browser/history/android/android_provider_backend.cc

+++ b/chrome/browser/history/android/android_provider_backend.cc

@@ -116,7 +116,7 @@ bool IsHistoryAndBookmarkRowValid(const HistoryAndBookmarkRow& row) {

void RunNotifyFaviconChanged(HistoryBackendNotifier* notifier,

scoped_ptr<std::set<GURL>> urls) {

- notifier->NotifyFaviconChanged(*(urls.get()));

+ notifier->NotifyFaviconsChanged(*(urls.get()), GURL());

}

void RunNotifyURLsModified(HistoryBackendNotifier* notifier,

« no previous file with comments | « no previous file | chrome/browser/history/android/android_provider_backend_unittest.cc » ('j') | no next file with comments »