Issue 1133453006: Merge to XFA: Fix a bunch of -Wunused-but-set-variable warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1133453006: Merge to XFA: Fix a bunch of -Wunused-but-set-variable warnings. (Closed)

Created:
5 years, 7 months ago by Lei Zhang

Modified:
5 years, 7 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix a bunch of -Wunused-but-set-variable warnings. Also fix a few nits and other errors along the way. Review URL: https://codereview.chromium.org/1098583002 Review URL: https://codereview.chromium.org/1135713004 (cherry picked from commit f0a169e6fd5718995fa6ef8749c8d16cdad84985) (cherry picked from commit 470408c2ffe71e99cebad0d1d6887f1723f02cef) R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ea7b333c73ea3e1847e79cabdd85853af67d6d6c

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -78 lines)			Patch
M	core/include/fxcrt/fx_system.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_page/pageint.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	core/src/fpdftext/fpdf_text.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	core/src/fpdftext/fpdf_text_int.cpp	View	4 chunks	+0 lines, -7 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_jpx_opj.cpp	View	13 chunks	+36 lines, -45 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp	View	8 chunks	+2 lines, -8 lines	0 comments	Download
M	core/src/fxge/dib/fx_dib_composite.cpp	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	core/src/fxge/dib/fx_dib_transform.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	core/src/fxge/ge/fx_ge_fontmap.cpp	View	1 chunk	+17 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

5 years, 7 months ago (2015-05-08 20:52:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ea7b333c73ea3e1847e79cabdd85853af67d6d6c (presubmit successful).